Repository navigation
[NIOFileSystem] Fallback to rename when renameat2 is not available - #3612
Merged
Merged
Conversation
Contributor
|
The API breakage check is a false positive on SPI. We can merge over it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are running into some issues when doing:
which results in crashes on some Android devices where
renameat2is not available:This PR adds functionality similar to what is already done for
EINVALon Linux, such that both lead to the same recovery: stat the destination, then plain rename() if absent.And for non-exclusive renames where it also fails to function not implemented, it falls back to plain
rename.