Repository navigation
Add variants of flatMap which can return EventLoopFuture<NonSendable> - #3634
Merged
Merged
Conversation
FranzBusch
approved these changes
Jul 3, 2026
FranzBusch
left a comment
Member
There was a problem hiding this comment.
LGTM. @Lukasa do you want to take a look as well?
Lukasa
enabled auto-merge (squash)
July 20, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, EventLoopFuture.flatMap requires the inner eventloop to have a Sendable type. This makes sense, because the value might move between eventloops, if the inner and outer future are not on the same EventLoop. However, this makes it impossible for users to use non Sendable values even when they know they're on the right eventloop
Modifications:
Add a new
flatMapIsolatedfunction which can be used in this case. It requires users to return an EventLoopFuture.Isolated to prove that they are on the same eventloopExample:
The above example gives a warning on the final line, because flatMap requires the inner future (
b) to have a Sendable type. That is because it doesn't know that a and b are on the same EventLoop.Here, it compiles without warnings. We can write assumeIsolated inside the flatMapIsolated closure because we know that the eventloops are the same. And therefore the new flatMapIsolated function does not have a Sendable requirement on its value