Skip to content

docs(fs): Clarify replaceItem moves the item (Fixes #3406) - #3674

Merged
glbrntt merged 1 commit into
apple:mainfrom
wasim-builds:docs/issue-3406-replaceItem-moves
Jul 27, 2026
Merged

glbrntt merged 1 commit into
apple:mainfrom
wasim-builds:docs/issue-3406-replaceItem-moves

Conversation

@wasim-builds

Copy link
Copy Markdown
Contributor

Hey @weissi! πŸ‘‹

This PR addresses #3406 by clarifying the documentation of replaceItem(at:withItemAt:). It explicitly states that this operation is identical to a move, and that the item at existingPath will be moved to the new location and no longer exist at its original path.

@glbrntt glbrntt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has lots of unrelated changes –– can you trim it down to what was intended?

@wasim-builds
wasim-builds force-pushed the docs/issue-3406-replaceItem-moves branch from 944a7b2 to e1e3cf3 Compare July 22, 2026 17:05
@wasim-builds

Copy link
Copy Markdown
Contributor Author

I've trimmed down the PR to only include the documentation changes for replaceItem as requested! Sorry about the mixup.

@glbrntt glbrntt added the semver/none No version bump required. label Jul 23, 2026
@glbrntt
glbrntt enabled auto-merge (squash) July 23, 2026 09:22
auto-merge was automatically disabled July 23, 2026 14:55

Head branch was pushed to by a user without write access

@wasim-builds
wasim-builds force-pushed the docs/issue-3406-replaceItem-moves branch from e1e3cf3 to d818bc5 Compare July 23, 2026 14:55
@wasim-builds

Copy link
Copy Markdown
Contributor Author

Rebased onto latest upstream/main. Only the documentation changes remain.

@glbrntt
glbrntt enabled auto-merge (squash) July 24, 2026 07:53
auto-merge was automatically disabled July 25, 2026 09:38

Head branch was pushed to by a user without write access

@wasim-builds
wasim-builds force-pushed the docs/issue-3406-replaceItem-moves branch from d818bc5 to 3be698b Compare July 25, 2026 09:38
@wasim-builds

Copy link
Copy Markdown
Contributor Author

Hey @weissi @Lukasa @glbrntt πŸ‘‹

This docs-only PR has been approved by @glbrntt and is ready to merge whenever the team has a moment. It's a small clarification to replaceItem(at:withItemAt:) documentation (Fixes #3406).

No urgency β€” just a friendly ping! Thanks for all you do maintaining Swift-NIO πŸ™

@glbrntt

glbrntt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@wasim-builds please stop @-mentioning maintainers to ping them for reviews; it doesn't speed things up and just adds noise. Maintainers have limited bandwidth and will get to PRs on their own schedule.

@glbrntt
glbrntt enabled auto-merge (squash) July 27, 2026 10:50
@glbrntt
glbrntt merged commit cb48799 into apple:main Jul 27, 2026
51 of 57 checks passed
wasim-builds added a commit to wasim-builds/swift-nio that referenced this pull request Jul 28, 2026
This change clarifies the documentation of
`replaceItem(at:withItemAt:)`. It explicitly states that this operation
is identical to a move, and that the item at `existingPath` will be
moved to the new location and no longer exist at its original path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants