Repository navigation
docs(fs): Clarify replaceItem moves the item (Fixes #3406) - #3674
Conversation
glbrntt
left a comment
There was a problem hiding this comment.
This PR has lots of unrelated changes ββ can you trim it down to what was intended?
944a7b2 to
e1e3cf3
Compare
|
I've trimmed down the PR to only include the documentation changes for replaceItem as requested! Sorry about the mixup. |
Head branch was pushed to by a user without write access
e1e3cf3 to
d818bc5
Compare
|
Rebased onto latest |
Head branch was pushed to by a user without write access
d818bc5 to
3be698b
Compare
|
Hey @weissi @Lukasa @glbrntt π This docs-only PR has been approved by @glbrntt and is ready to merge whenever the team has a moment. It's a small clarification to No urgency β just a friendly ping! Thanks for all you do maintaining Swift-NIO π |
|
@wasim-builds please stop @-mentioning maintainers to ping them for reviews; it doesn't speed things up and just adds noise. Maintainers have limited bandwidth and will get to PRs on their own schedule. |
This change clarifies the documentation of `replaceItem(at:withItemAt:)`. It explicitly states that this operation is identical to a move, and that the item at `existingPath` will be moved to the new location and no longer exist at its original path.
Hey @weissi! π
This PR addresses #3406 by clarifying the documentation of
replaceItem(at:withItemAt:). It explicitly states that this operation is identical to a move, and that the item atexistingPathwill be moved to the new location and no longer exist at its original path.