Repository navigation
Implement customisation point for scheduled callback on isolated EL - #3679
Merged
Merged
Conversation
Motivation: The schedule callback mechanism on `EventLoop` has an equivalent on an isolated `EventLoop`. The default isolated implementation puts the hander in a loop bound box and calls the non-isolated version. This is okay but introduces a number of additional "in event loop" checks which are required for correctness in the general case (i.e. not called from an isolated event loop). Modifications: - Implement the customisation point directly to avoid the additional checks (the are unecessary by definition of being on the isolated event loop). - Add benchmarks Result: On the isolated event loop, in micro benchmarks: - scheduleTask is ~1.6x faster - scheduleCallback is ~2x faster
FranzBusch
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The schedule callback mechanism on
EventLoophas an equivalent on an isolatedEventLoop. The default isolated implementation puts the hander in a loop bound box and calls the non-isolated version.This is okay but introduces a number of additional "in event loop" checks which are required for correctness in the general case (i.e. not called from an isolated event loop).
Modifications:
Result:
On the isolated event loop, in micro benchmarks: