Repository navigation
Translate ByteToMessageDecoderVerifierTest to Swift Testing - #3730
Merged
fabianfett merged 3 commits intoSep 3, 2026
Merged
Conversation
### Motivation We want to extend `ByteToMessageDecoderVerifierTest` with tests that verify non-copyable decoders. Instead of adding more XCTests, lets first move all existing tests to swift-testing. ### Changes - Mechanical translation of `ByteToMessageDecoderVerifierTest` from XCTest to Swift Testing. ### Result No behaviour change. We can write the new tests in Swift Testing.
aryan-25
requested changes
Sep 3, 2026
| } | ||
|
|
||
| XCTAssertThrowsError( | ||
| let error = #expect(throws: VerificationError.self) { |
Contributor
There was a problem hiding this comment.
We should just replace this with:
Suggested change
| let error = #expect(throws: VerificationError.self) { | |
| let error = try #require(throws: VerificationError.self) { |
Then we can get rid of guard let error else { return } a few lines below.
This will require marking the test function itself as throws.
Same applies for the other tests below.
aryan-25
approved these changes
Sep 3, 2026
fabianfett
enabled auto-merge (squash)
September 3, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to extend
ByteToMessageDecoderVerifierTestwith tests that verify non-copyable decoders. Instead of adding more XCTests, lets first move all existing tests to swift-testing.Changes
ByteToMessageDecoderVerifierTestfrom XCTest to Swift Testing.Result
No behaviour change. We can write the new tests in Swift Testing.