Repository navigation
Android CI builds shouldn't link the stdlib statically - #3739
Merged
Merged
Conversation
Contributor
Author
|
I'll let the Android job pass first and then I'll back out the branch override before merging. |
Contributor
Author
|
Ok the passing job when the branch is overriden is here: https://github.com/apple/swift-nio/actions/runs/34365847573/job/102514275466?pr=3739 Undoing the branch override now. |
simonjbeaumont
approved these changes
Sep 9, 2026
czechboy0
enabled auto-merge (squash)
September 9, 2026 14:56
FranzBusch
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We started seeing issues in Swift Log with building for Android when using types from the Concurrency module.
Folks from the Android workgroup suggested we don't build with static stdlib, and I confirmed that removing it fixes the issue: https://github.com/apple/swift-log/actions/runs/34365246956/job/102512196662?pr=509
Modifications:
Links the stdlib dynamically (default) for Android.
Result:
Unblock Swift Log's CI. This topic can be further discussed in the ongoing GitHub Actions unification.