Skip to content

Align workspace member matching with glob expansion - #21341

Merged
zanieb merged 2 commits into
mainfrom
zanieb/reproduce-21337-workspace-member-glob
Aug 31, 2026
Merged

zanieb merged 2 commits into
mainfrom
zanieb/reproduce-21337-workspace-member-glob

Conversation

@zanieb

@zanieb zanieb commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Workspace discovery can claim a deeply nested project through a one-level member glob such as packages/*, even though member collection expands that glob to direct children only. If the direct child is skippedβ€”for example, because it contains only gitignored filesβ€”the nested project is absent from the collected members and uv aborts instead of treating it as standalone.

Make the membership check use the same path-separator semantics as member collection. After this change, packages/* selects only direct children; a project at packages/foo/nested remains standalone unless the workspace explicitly includes that depth, for example with packages/*/*, packages/**/nested, or the exact path. Add coverage for both the standalone and recursive-member cases. This removes the workspace-discovery panic identified in #21337 without changing intentionally recursive or explicit member configurations.

Closes #21337.

@zanieb zanieb added the internal:testing Internal testing of behavior label Aug 28, 2026
@zanieb
zanieb marked this pull request as ready for review August 28, 2026 17:29
@zanieb
zanieb requested a review from konstin August 28, 2026 18:21
@zanieb
zanieb force-pushed the zanieb/reproduce-21337-workspace-member-glob branch from e0ce4a6 to 27bdcff Compare August 31, 2026 14:04
@zanieb zanieb changed the title Add coverage for nested workspace discovery Align workspace member matching with glob expansion Aug 31, 2026
@zanieb zanieb added bug Something isn't working and removed internal:testing Internal testing of behavior labels Aug 31, 2026
@zanieb
zanieb merged commit 2617c08 into main Aug 31, 2026
90 checks passed
@zanieb
zanieb deleted the zanieb/reproduce-21337-workspace-member-glob branch August 31, 2026 14:29
luketainton pushed a commit to luketainton/repos_labmcp that referenced this pull request Aug 31, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ghcr.io/astral-sh/uv](https://github.com/astral-sh/uv) | final | patch | `0.12.7` β†’ `0.12.8` |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/51) for more information.

---

### Release Notes

<details>
<summary>astral-sh/uv (ghcr.io/astral-sh/uv)</summary>

### [`v0.12.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0128)

Released on 2026-08-31.

##### Enhancements

- Warn about invalid tool directories and continue upgrading valid tools with `uv tool upgrade --all` ([#&#8203;21368](astral-sh/uv#21368))

##### Preview features

- Deduplicate identical files within and across cached wheels with the `content-addressed-cache` preview feature ([#&#8203;21327](astral-sh/uv#21327))
- Reduce allocations while extracting content-addressed wheels by reusing the hashing buffer across files ([#&#8203;21340](astral-sh/uv#21340))
- Speed up content-addressed cache cleanup on macOS by reading hard-link counts in bulk ([#&#8203;21344](astral-sh/uv#21344))

##### Performance

- Prevent concurrent uv processes from downloading and extracting the same remote wheel more than once ([#&#8203;21379](astral-sh/uv#21379))
- Speed up dependency graph construction from large lockfiles by indexing packages during traversal ([#&#8203;21373](astral-sh/uv#21373))
- Extend indexed lockfile traversal to exports, dependency trees, audits, and freshness checks ([#&#8203;21377](astral-sh/uv#21377))
- Speed up warm resolutions by reducing repeated marker interner work ([#&#8203;21300](astral-sh/uv#21300))

##### Bug fixes

- Do not trust hashes from direct URLs discovered only in wheel metadata when installing with `--require-hashes` ([#&#8203;21348](astral-sh/uv#21348))
- Use a compatible Azure Storage API version for anonymous and authenticated requests, allowing credential retries when public access is disabled ([#&#8203;21366](astral-sh/uv#21366))
- Redact Azure shared access signature (`sig`) query parameters from displayed URLs ([#&#8203;21360](astral-sh/uv#21360))
- Treat projects below one-level workspace member globs as standalone instead of aborting workspace discovery ([#&#8203;21341](astral-sh/uv#21341))

##### Other changes

- Update `astral-tokio-tar` to 0.7.0 and use effective sizes when tracking extracted hard links ([#&#8203;21346](astral-sh/uv#21346))

</details>

---

### Configuration

πŸ“… **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

β™» **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41Mi4wIiwidXBkYXRlZEluVmVyIjoiNDQuNTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tainton.uk/repos/labmcp/pulls/52
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
hbjydev pushed a commit to hbjydev/phoebe that referenced this pull request Sep 3, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uv](https://github.com/astral-sh/uv) | tools | patch | `0.12.7` β†’ `0.12.9` |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/141) for more information.

---

### Release Notes

<details>
<summary>astral-sh/uv (uv)</summary>

### [`v0.12.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0129)

[Compare Source](astral-sh/uv@0.12.8...0.12.9)

Released on 2026-09-01.

##### Python

- Add CPython 3.15.0rc2 ([#&#8203;21413](astral-sh/uv#21413), [#&#8203;21415](astral-sh/uv#21415))

##### Enhancements

- Add `--no-locked` and `--no-frozen` to disable lock modes enabled by `UV_LOCKED` and `UV_FROZEN` for a single invocation ([#&#8203;21408](astral-sh/uv#21408))
- Report the exact command-line lock-mode flag in warnings and errors ([#&#8203;21402](astral-sh/uv#21402))

##### Performance

- Speed up cold wheel installs by extracting each streaming ZIP archive in a single blocking task and reusing buffers across files ([#&#8203;21372](astral-sh/uv#21372))

##### Bug fixes

- Update `async_http_range_reader` to 0.11.1 to address a potential memory-safety issue when reading metadata ranges from untrusted wheels ([#&#8203;21401](astral-sh/uv#21401))
- Remove sensitive headers when redirects cross authentication realms, including same-host redirects that change URL schemes ([#&#8203;21382](astral-sh/uv#21382))
- Redact secrets in signed URLs from retry diagnostics, including nested request errors ([#&#8203;21381](astral-sh/uv#21381))
- Give `--locked`, `--frozen`, `--check`, and `--check-exists` precedence over conflicting `UV_LOCKED` and `UV_FROZEN` values ([#&#8203;21396](astral-sh/uv#21396))
- Prevent concurrent uv processes from redundantly extracting the same local or source-built wheel ([#&#8203;21400](astral-sh/uv#21400))

### [`v0.12.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0128)

[Compare Source](astral-sh/uv@0.12.7...0.12.8)

Released on 2026-08-31.

##### Enhancements

- Warn about invalid tool directories and continue upgrading valid tools with `uv tool upgrade --all` ([#&#8203;21368](astral-sh/uv#21368))

##### Preview features

- Deduplicate identical files within and across cached wheels with the `content-addressed-cache` preview feature ([#&#8203;21327](astral-sh/uv#21327))
- Reduce allocations while extracting content-addressed wheels by reusing the hashing buffer across files ([#&#8203;21340](astral-sh/uv#21340))
- Speed up content-addressed cache cleanup on macOS by reading hard-link counts in bulk ([#&#8203;21344](astral-sh/uv#21344))

##### Performance

- Prevent concurrent uv processes from downloading and extracting the same remote wheel more than once ([#&#8203;21379](astral-sh/uv#21379))
- Speed up dependency graph construction from large lockfiles by indexing packages during traversal ([#&#8203;21373](astral-sh/uv#21373))
- Extend indexed lockfile traversal to exports, dependency trees, audits, and freshness checks ([#&#8203;21377](astral-sh/uv#21377))
- Speed up warm resolutions by reducing repeated marker interner work ([#&#8203;21300](astral-sh/uv#21300))

##### Bug fixes

- Do not trust hashes from direct URLs discovered only in wheel metadata when installing with `--require-hashes` ([#&#8203;21348](astral-sh/uv#21348))
- Use a compatible Azure Storage API version for anonymous and authenticated requests, allowing credential retries when public access is disabled ([#&#8203;21366](astral-sh/uv#21366))
- Redact Azure shared access signature (`sig`) query parameters from displayed URLs ([#&#8203;21360](astral-sh/uv#21360))
- Treat projects below one-level workspace member globs as standalone instead of aborting workspace discovery ([#&#8203;21341](astral-sh/uv#21341))

##### Other changes

- Update `astral-tokio-tar` to 0.7.0 and use effective sizes when tracking extracted hard links ([#&#8203;21346](astral-sh/uv#21346))

</details>

---

### Configuration

πŸ“… **Schedule**: (in timezone Europe/London)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41Mi4xIiwidXBkYXRlZEluVmVyIjoiNDQuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://forgejo.hayden.moe/hayden/phoebe/pulls/430

This branch was previously deployed

1 inactive deployment
automations β€” 80a853dc Deployed Aug 31, 2026 by zanieb via review / security review #45533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uvx crashes with SIGABRT / abort() on macOS when launched non-interactively via subprocess stdio piping

2 participants