Skip to content

feat(ansible): download simpl_prediction, ptv3, lidar_frnet, calibration_status_classifier from Hugging Face - #7224

Merged
xmfcx merged 3 commits into
mainfrom
feat/ansible-hf-artifacts-batch-a
Jul 21, 2026
Merged

xmfcx merged 3 commits into
mainfrom
feat/ansible-hf-artifacts-batch-a

Conversation

@xmfcx

@xmfcx xmfcx commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Batch A of the ML artifact hosting migration to Hugging Face: replaces the per-file get_url tasks of simpl_prediction, ptv3, lidar_frnet, and calibration_status_classifier with single pinned hf download --revision <tag> tasks, following the lidar_centerpoint pattern. Also updates the role README's checksum sentence to describe both download mechanisms.

Model Hugging Face repo Tag Replaces
simpl_prediction AutowareFoundation/simpl_prediction v0.1 perception/models/simpl/v0.1.0
ptv3 AutowareFoundation/ptv3 v4.0 perception/models/ptv3/v4
lidar_frnet AutowareFoundation/lidar_frnet v2.0 perception/models/frnet/v2
calibration_status_classifier AutowareFoundation/calibration_status_classifier v2.0 sensing/models/calibration_status_classifier/v2

Verification

  • Every file in the four Hugging Face repos was sha256-verified byte-identical to the files previously pinned by the removed checksum: entries, both before upload and via round-trip download after upload.
  • The four exact hf download commands in this diff were run locally; all 13 downloaded model and param files hash-match the recorded values.
  • pre-commit (yamllint, prettier) passes on the changed files.
  • The run:health-check label runs the full artifacts playbook in CI with HF_TOKEN.

Notes for reviewers: like the lidar_centerpoint task, the hf tasks run without become (files are user-owned instead of root-owned; consumers only read them), and hf download additionally places the model card and deploy_metadata.yaml in each model directory.

…ion_status_classifier from Hugging Face

Replace the per-file get_url tasks of the four batch A models with single
pinned hf download tasks, following the lidar_centerpoint pattern. Each
Hugging Face model repo was verified byte-identical to the previously
pinned files, and each task pins a version tag.

Part of #7223.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
xmfcx requested a review from oguzkaganozt as a code owner July 20, 2026 18:21
@xmfcx xmfcx added the type:installation Issues or improvements related to the installation process of the software. label Jul 20, 2026
@xmfcx
xmfcx requested a review from youtalk as a code owner July 20, 2026 18:21
@xmfcx xmfcx added the run:health-check Run health-check label Jul 20, 2026
@xmfcx xmfcx added type:installation Issues or improvements related to the installation process of the software. run:health-check Run health-check labels Jul 20, 2026
@xmfcx xmfcx self-assigned this Jul 20, 2026
@xmfcx
xmfcx requested a review from YoshiRi July 20, 2026 18:21
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx

xmfcx commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

The migration task was mostly automated but I verified at many intermediary stages to ensure the task is completed correctly.

I did a self-review and confirmed all the replaced files have the correct sha signatures. And this PR should not change the behavior of anything since it just pulls in the same files.

Also ansible role is tested by the CI: https://github.com/autowarefoundation/autoware/actions/runs/29767437404/job/88441050627?pr=7224#step:5:313

@YoshiRi @mitsudome-r @ktro2828 @amadeuszsz please review 🙏

Comment thread ansible/roles/artifacts/tasks/main.yaml Resolved
xmfcx added 2 commits July 20, 2026 22:14
Address review feedback: the version string was duplicated between the
task name and the --revision flag, which is error prone to update. Define
it as a task-level revision var and template both places. Applied to all
five hf download tasks, including the pre-existing lidar_centerpoint one,
to keep the file uniform.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
…acts

Templating the injected top-level ansible_env fact emits an
INJECT_FACTS_AS_VARS deprecation warning on every hf download task (once
for the PATH environment and once through the data_dir default), and the
injection will be removed in ansible-core 2.24. Switch the artifacts role
to the recommended ansible_facts.env form.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx

xmfcx commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Also here d208d7e I applied this pattern:

  • from: ansible_env.HOME
  • to: ansible_facts.env.HOME

To conform to this migration guide: https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_13.html#inject-facts-as-vars

(This is not an issue for the ansible 10 that we use but on my machine I have latest ansible 14 installed)

@xmfcx
xmfcx requested a review from amadeuszsz July 20, 2026 19:35

@youtalk youtalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reproduced the ansible scripts and it works correctly. There is no difference from the gdown version.
LGTM

@mergify

mergify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

TomcoGame pushed a commit to TomcoGame/Autoware-Assurance-Stack that referenced this pull request Oct 25, 2026
…ion_status_classifier from Hugging Face (autowarefoundation#7224)

* feat(ansible): download simpl_prediction, ptv3, lidar_frnet, calibration_status_classifier from Hugging Face

Replace the per-file get_url tasks of the four batch A models with single
pinned hf download tasks, following the lidar_centerpoint pattern. Each
Hugging Face model repo was verified byte-identical to the previously
pinned files, and each task pins a version tag.

Part of autowarefoundation#7223.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check type:installation Issues or improvements related to the installation process of the software.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants