Repository navigation
chore: drop the orphaned tensorrt_rtmdet artifact and the trt_batched_nms repos entry - #7253
Merged
Merged
Conversation
…_nms repos entry autoware_tensorrt_rtmdet was never merged into autoware_universe. autowarefoundation/autoware_universe#8165 is closed and the parent issue autowarefoundation/autoware_universe#7235 is closed as not planned, so the model artifact and its TensorRT plugin dependency have no consumer. Every fresh install still downloaded tensorrt_rtmdet_onnx_models.tar.gz (462 MB, about 957 MB on disk because the tarball is never deleted after extraction), and every vcs import still cloned trt_batched_nms. Remove the three tensorrt_rtmdet tasks from the artifacts role, drop the universe/external/trt_batched_nms entry, and correct two README sentences: the role no longer extracts anything, and the models still hosted by Web.Auto are now just diffusion_planner and tensorrt_vad. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
xmfcx
requested review from
isamu-takagi,
mitsudome-r and
youtalk
as code owners
August 5, 2026 09:04
Contributor
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This was referenced Aug 5, 2026
mitsudome-r
approved these changes
Aug 5, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
youtalk
pushed a commit
to autowarefoundation/openadkit
that referenced
this pull request
Aug 13, 2026
…115) trt_batched_nms is being removed from autowarefoundation/autoware: autowarefoundation/autoware#7253 drops the universe/external/trt_batched_nms entry from repositories/autoware.repos, because its only consumer was autoware_tensorrt_rtmdet, which was never merged and whose parent issue autowarefoundation/autoware_universe#7235 is now closed as not planned. build-all-images.yaml derives its lockfile from that repos file, so once #7253 merges vcs import no longer creates the directory and both --base-paths entries point at a path that does not exist. colcon skips missing base paths and exits 0, so this is dead config rather than a break, but it should not linger. Remove the entry from both the plain and the CUDA Dockerfile. The only observable change is that newly built sensing-perception images no longer contain libtrt_batched_nms_plugin.so, which nothing loads. Tracked in autowarefoundation/autoware#7252. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
14 tasks done
TomcoGame
pushed a commit
to TomcoGame/Autoware-Assurance-Stack
that referenced
this pull request
Oct 25, 2026
…_nms repos entry (autowarefoundation#7253) autoware_tensorrt_rtmdet was never merged into autoware_universe. autowarefoundation/autoware_universe#8165 is closed and the parent issue autowarefoundation/autoware_universe#7235 is closed as not planned, so the model artifact and its TensorRT plugin dependency have no consumer. Every fresh install still downloaded tensorrt_rtmdet_onnx_models.tar.gz (462 MB, about 957 MB on disk because the tarball is never deleted after extraction), and every vcs import still cloned trt_batched_nms. Remove the three tensorrt_rtmdet tasks from the artifacts role, drop the universe/external/trt_batched_nms entry, and correct two README sentences: the role no longer extracts anything, and the models still hosted by Web.Auto are now just diffusion_planner and tensorrt_vad. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
autoware_tensorrt_rtmdetwas never merged intoautoware_universe. feat(autoware_tensorrt_rtmdet): add tensorrt rtmdet model autoware_universe#8165 is closed and Implement RTMDet to Perception Pipeline autoware_universe#7235 is closed as not planned, so the model artifact and its TensorRT plugin dependency have no consumer. Tracked in Remove the orphaned tensorrt_rtmdet artifact and its trt_batched_nms dependency #7252.Costs removed:
--tags artifactsinstall downloadstensorrt_rtmdet_onnx_models.tar.gz(462 MB) and extracts it, leaving both the tarball and its contents on disk (about 957 MB total, because theunarchivetask never deletes the source tarball). The pinned checksum means it is fetched once per machine, not once per run.vcs importclonesautowarefoundation/trt_batched_nms, which has no consumer in the workspace today. Nopackage.xmlorCMakeLists.txtundersrc/references it. The only package that ever declared it was the unmergedautoware_tensorrt_rtmdet, which resolvedlibtrt_batched_nms_plugin.sothrough$(find-pkg-prefix trt_batched_nms)for TensorRT todlopen.This resolves the last outstanding decision item in #7223, as "dropped, no consumer".
Changes:
tensorrt_rtmdettasks fromansible/roles/artifacts/tasks/main.yaml.universe/external/trt_batched_nmsfromrepositories/autoware.repos.ansible/roles/artifacts/README.md: rtmdet was the onlyunarchivetask in the role, so it no longer extracts anything. Also name the two models still on Web.Auto, since that is now justdiffusion_plannerandtensorrt_vad.Note this does not claim the role is fully migrated to Hugging Face: 15
get_urltasks remain fordiffusion_plannerandtensorrt_vad, which move in a separate batch.Not in scope, tracked in #7252:
autowarefoundation/openadkit(two Dockerfiles) andautowarefoundation/autoware-deb-packages(sources.repos, pinned to a different SHA) each carry their own reference. The S3 object itself stays: several out-of-org projectswgetit directly in their installers, so deleting it belongs to the hosting decommission in #7223 as a separately announced decision.Companion docs PR: autowarefoundation/autoware-documentation#822, which should merge first.
How was this PR tested?
repositories/autoware.reposgoes from 32 to 31 entries.ansible-lint ansible/roles/artifacts/: 0 failures, 0 warnings, profileproduction.pre-commit run --fileson all three: markdownlint, prettier, yamllint pass.git grep -in "rtmdet\|trt_batched_nms"returns nothing on the branch.unarchivetasks and 15get_urltasks, which is what the two README edits assert.Effects on system behavior
No functional effect. Nothing in
autoware_universeorautoware_corebuilds againsttrt_batched_nmsor reads from~/autoware_data/ml_models/tensorrt_rtmdet.vcs importhas no prune, so existing workspaces keepsrc/universe/external/trt_batched_nmsand colcon keeps building it until it is removed by hand. To reclaim the space:rm -rf src/universe/external/trt_batched_nms ~/autoware_data/ml_models/tensorrt_rtmdet