Skip to content

chore: drop the orphaned tensorrt_rtmdet artifact and the trt_batched_nms repos entry - #7253

Merged
xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:chore/drop-rtmdet-artifacts
Aug 5, 2026
Merged

xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:chore/drop-rtmdet-artifacts

Conversation

@xmfcx

@xmfcx xmfcx commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Costs removed:

  • Every fresh --tags artifacts install downloads tensorrt_rtmdet_onnx_models.tar.gz (462 MB) and extracts it, leaving both the tarball and its contents on disk (about 957 MB total, because the unarchive task never deletes the source tarball). The pinned checksum means it is fetched once per machine, not once per run.
  • Every vcs import clones autowarefoundation/trt_batched_nms, which has no consumer in the workspace today. No package.xml or CMakeLists.txt under src/ references it. The only package that ever declared it was the unmerged autoware_tensorrt_rtmdet, which resolved libtrt_batched_nms_plugin.so through $(find-pkg-prefix trt_batched_nms) for TensorRT to dlopen.

This resolves the last outstanding decision item in #7223, as "dropped, no consumer".

Changes:

  • Remove the three tensorrt_rtmdet tasks from ansible/roles/artifacts/tasks/main.yaml.
  • Remove universe/external/trt_batched_nms from repositories/autoware.repos.
  • ansible/roles/artifacts/README.md: rtmdet was the only unarchive task in the role, so it no longer extracts anything. Also name the two models still on Web.Auto, since that is now just diffusion_planner and tensorrt_vad.

Note this does not claim the role is fully migrated to Hugging Face: 15 get_url tasks remain for diffusion_planner and tensorrt_vad, which move in a separate batch.

Not in scope, tracked in #7252: autowarefoundation/openadkit (two Dockerfiles) and autowarefoundation/autoware-deb-packages (sources.repos, pinned to a different SHA) each carry their own reference. The S3 object itself stays: several out-of-org projects wget it directly in their installers, so deleting it belongs to the hosting decommission in #7223 as a separately announced decision.

Companion docs PR: autowarefoundation/autoware-documentation#822, which should merge first.

How was this PR tested?

  • Both edited YAML files parse under PyYAML; repositories/autoware.repos goes from 32 to 31 entries.
  • ansible-lint ansible/roles/artifacts/: 0 failures, 0 warnings, profile production.
  • pre-commit run --files on all three: markdownlint, prettier, yamllint pass.
  • git grep -in "rtmdet\|trt_batched_nms" returns nothing on the branch.
  • The artifacts role now contains 0 unarchive tasks and 15 get_url tasks, which is what the two README edits assert.

Effects on system behavior

No functional effect. Nothing in autoware_universe or autoware_core builds against trt_batched_nms or reads from ~/autoware_data/ml_models/tensorrt_rtmdet.

vcs import has no prune, so existing workspaces keep src/universe/external/trt_batched_nms and colcon keeps building it until it is removed by hand. To reclaim the space:

rm -rf src/universe/external/trt_batched_nms ~/autoware_data/ml_models/tensorrt_rtmdet

…_nms repos entry

autoware_tensorrt_rtmdet was never merged into autoware_universe.
autowarefoundation/autoware_universe#8165 is closed and the parent issue
autowarefoundation/autoware_universe#7235 is closed as not planned, so the model
artifact and its TensorRT plugin dependency have no consumer.

Every fresh install still downloaded tensorrt_rtmdet_onnx_models.tar.gz (462 MB,
about 957 MB on disk because the tarball is never deleted after extraction), and
every vcs import still cloned trt_batched_nms.

Remove the three tensorrt_rtmdet tasks from the artifacts role, drop the
universe/external/trt_batched_nms entry, and correct two README sentences: the
role no longer extracts anything, and the models still hosted by Web.Auto are
now just diffusion_planner and tensorrt_vad.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
xmfcx requested a review from oguzkaganozt as a code owner August 5, 2026 09:04
@xmfcx xmfcx added the run:health-check Run health-check label Aug 5, 2026
@xmfcx xmfcx added the run:health-check Run health-check label Aug 5, 2026
@xmfcx xmfcx self-assigned this Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@xmfcx
xmfcx merged commit a03d8ef into autowarefoundation:main Aug 5, 2026
34 of 41 checks passed
@xmfcx
xmfcx deleted the chore/drop-rtmdet-artifacts branch August 5, 2026 14:04
youtalk pushed a commit to autowarefoundation/openadkit that referenced this pull request Aug 13, 2026
…115)

trt_batched_nms is being removed from autowarefoundation/autoware:
autowarefoundation/autoware#7253 drops the universe/external/trt_batched_nms
entry from repositories/autoware.repos, because its only consumer was
autoware_tensorrt_rtmdet, which was never merged and whose parent issue
autowarefoundation/autoware_universe#7235 is now closed as not planned.

build-all-images.yaml derives its lockfile from that repos file, so once #7253
merges vcs import no longer creates the directory and both --base-paths entries
point at a path that does not exist. colcon skips missing base paths and exits
0, so this is dead config rather than a break, but it should not linger.

Remove the entry from both the plain and the CUDA Dockerfile. The only
observable change is that newly built sensing-perception images no longer
contain libtrt_batched_nms_plugin.so, which nothing loads.

Tracked in autowarefoundation/autoware#7252.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
TomcoGame pushed a commit to TomcoGame/Autoware-Assurance-Stack that referenced this pull request Oct 25, 2026
…_nms repos entry (autowarefoundation#7253)

autoware_tensorrt_rtmdet was never merged into autoware_universe.
autowarefoundation/autoware_universe#8165 is closed and the parent issue
autowarefoundation/autoware_universe#7235 is closed as not planned, so the model
artifact and its TensorRT plugin dependency have no consumer.

Every fresh install still downloaded tensorrt_rtmdet_onnx_models.tar.gz (462 MB,
about 957 MB on disk because the tarball is never deleted after extraction), and
every vcs import still cloned trt_batched_nms.

Remove the three tensorrt_rtmdet tasks from the artifacts role, drop the
universe/external/trt_batched_nms entry, and correct two README sentences: the
role no longer extracts anything, and the models still hosted by Web.Auto are
now just diffusion_planner and tensorrt_vad.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants