Settings window: text fields not saved on Done button click

[ishii-masaki-646]

Summary

Text entry fields in the Settings window (Network tab) are only saved when the user presses Enter inside the field. Clicking the Done button closes the window without persisting the values.

Affected fields: Proxy, Mainline-PPA URL, User Agent String.

Steps to reproduce

1. Open Settings → Network tab
2. Change the Proxy field (e.g. from empty to http://127.0.0.1:8118)
3. Click Done (without pressing Enter first)
4. Reopen Settings → the field has reverted to its previous value

Workaround

Press Enter in the field before clicking Done.

Cause

Each Gtk.Entry only writes its value back to the app config via activate.connect, which fires on Enter key press. The Done button does not trigger activate on the entries, so unsaved values are lost.

Suggested fix

Connect the Done button handler (or the window's destroy / hide signal) to read back all entry fields, e.g.:

btn_done.clicked.connect(() => {
    App.all_proxy = ent_proxy.get_text();
    App.ppa_uri = ent_ppaurl.get_text().strip();
    App.user_agent = ent_useragent.get_text();
    // ... other fields
    this.destroy();
});

Environment

• mainline 1.4.14
• Ubuntu 24.04
• GTK 3

[bkw777]

Treating Done like Save sounds reasonable. Thanks.

[bkw777]

At least for now I decided intentionally not to include the window decoration close button, so the X button acts like cancel. Which is probably wrong because all of the other settings that aren't text input always save immediately and X doesn't revert them, so it's inconsistent.