Repository navigation
fix(frontend): keep project thread kebab inside the sidebar - #5682
Merged
WillemJiang merged 2 commits intoSep 22, 2026
Merged
Conversation
In grouped mode the sidebar indents a project's thread rows with a nested SidebarMenu carrying ml-4, but SidebarMenu defaults to w-full. Width 100% plus a 16px left margin overflows the sidebar by 16px, so the absolutely positioned row kebab (right-1) lands past the visible edge and gets clipped. The Archived group nests one level deeper and overflows 32px, hiding its kebabs entirely. Swap w-full for w-auto on both indented menus so the block-level flex container fills the remaining width minus its margin. A dom test renders ProjectsSection in grouped mode from seeded query caches and pins that every indented menu drops w-full while the root menu keeps it. Fixes bytedance#5681
WillemJiang
approved these changes
Sep 22, 2026
vieenrose
pushed a commit
to vieenrose/deer-flow
that referenced
this pull request
Sep 25, 2026
…e#5682) In grouped mode the sidebar indents a project's thread rows with a nested SidebarMenu carrying ml-4, but SidebarMenu defaults to w-full. Width 100% plus a 16px left margin overflows the sidebar by 16px, so the absolutely positioned row kebab (right-1) lands past the visible edge and gets clipped. The Archived group nests one level deeper and overflows 32px, hiding its kebabs entirely. Swap w-full for w-auto on both indented menus so the block-level flex container fills the remaining width minus its margin. A dom test renders ProjectsSection in grouped mode from seeded query caches and pins that every indented menu drops w-full while the root menu keeps it. Fixes bytedance#5681
ethan-jiang-1
pushed a commit
to ethan-jiang-1/deer-flow
that referenced
this pull request
Sep 25, 2026
锚点 bytedance#6 (v2.1.0-rc0, 769589e) → bytedance#7 (v2.1.0, 345f08b),10 commits / 90 files。 注意 v2.1.0 tag 打在 2.1.x-dev 上,与 upstream/main 已在 rc0 处分叉(main 另有 189 commits 待 sync bytedance#8)。 源码侧实质变更 → digest 校正: - 0025_repair_run_change_seq(bytedance#5517/bytedance#5516):修复被"插队"的 0023_run_change_seq 留下的 schema 空洞;补注册 RunChangeClockRow / UserPreferenceRow - 线程删除全量清理(bytedance#5535):DELETE /api/threads/{id} 持 durable delete reservation, 依次清理文件系统/checkpoints/历史 run(只删 operation_kind="run")/events/feedback/thread_meta - 事件存储变更串行域 + owner-scoped 删除签名(bytedance#5535) - CI:6 个 workflow push 触发改 *-dev 通配,skill-review-ci 显式钉 2.1.x-dev(bytedance#5765) - frontend:Projects 侧栏嵌套 SidebarMenu 加 w-auto(bytedance#5681/bytedance#5682) - 文档:subagents 11 页手册 / extensions 10 页手册,root AGENTS.md 精简 同时校正文档侧漂移:AGENTS.md 行号引用与计数、仓库行数/方法数、 _faq_on_digested 14 处基线标注 rc0→v2.1.0。 SYNC.md / SYNC_LOG.md bytedance#7 / UPDATE_PLAN_7.md 已同步记录。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5681
Why
In the sidebar's grouped Projects mode, the
…(kebab) button on chat rows listed under a project is pushed past the sidebar's right edge and clipped, so it is hard to see and to click. Rows under the collapsed Archived group are nested one level deeper and lose the button entirely. The flat chat list is unaffected, which is why this slipped through: the project groups are the only indentedSidebarMenuin the sidebar.What changed
frontend/src/components/workspace/projects-section.tsx: the indented nested menus carryml-4but inheritedSidebarMenu'sw-full, so they were100% + 16pxwide (32px for the doubly nested Archived rows) and their absolutely positionedright-1action landed outside the container. Both menus now usew-autoso the block-level flex container fills the remaining width minus its margin.Surface area
frontend/backend/applanggraph.json, or prompt changedocker/or sandboxed executionskills/backend/pyproject.tomlorfrontend/package.json(say what it buys us)Screenshots / Recording
Entry point: sidebar → Projects header → display-mode toggle ("Group chats by project") → hover a chat row under a project.
Before (kebab clipped at the sidebar edge):

After (kebab fully visible):

Bug fix verification
frontend/tests/unit/components/workspace/projects-section-nested-menu.dom.test.tsxmainand green on this branch? yes — it rendersProjectsSectionin grouped mode from seeded query caches (active project, archived project, one chat each), expands the Archived group, and asserts that the menu around every row kebab carriesw-autoand notw-fullwhile the root menu keepsw-full. With the source change stashed it fails on thew-autoassertion; with it applied it passes.Validation
cd frontend && pnpm check(eslint +tsc --noEmit) — cleancd frontend && pnpm exec prettier --checkon both changed files — cleancd frontend && pnpm rstest run projects-section-nested-menu— pass (and fails with the fix reverted)cd frontend && pnpm rstest run thread-sidebar-item-delete-gating— pass (shares the row component)cd frontend && pnpm test(full unit suite, 220 files) — 1868 pass, 27 pre-existing failures that are identical with this change and with the new test file removed:tests/unit/core/models/favorites-store.dom.test.tsxandtests/unit/core/settings/user-preferences.dom.test.tsxthrowCannot read properties of undefined (reading 'clear')fromwindow.localStorage.clear()in theirbeforeEach, i.e. happy-dom exposes nolocalStorageunder the local toolchain (Node v26.8.1, pnpm 11.22.0). Neither file imports the changed component.sidecar-delete-gating.dom.test.tsxadditionally flaked once in the full run with an unhandledHTTP 404from a livemake devserver onlocalhost:3000; it passes alone.pnpm build, E2E.make devstack: the kebab on project-grouped rows is back inside the sidebar.AI assistance
Tool(s) used: Claude Code
How you used it: Claude Code traced the clipping from the component's nested
SidebarMenuclasses and theui/sidebarprimitive styles, proposed thew-autofix, wrote the dom regression test, verified it goes red without the fix, filed #5681, and drafted this description. The reporter reproduced the bug and checked the fix in the running app.