Skip to content

refactor(is-plain-object): replace with is-plain-obj - #1191

Merged
chimurai merged 1 commit into
masterfrom
is-plain-obj
Apr 5, 2026
Merged

chimurai merged 1 commit into
masterfrom
is-plain-obj

Conversation

@chimurai

@chimurai chimurai commented Apr 5, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Replaced an internal plain-object helper dependency with an alternative implementation to streamline checks.
    • Removed two local package patches that previously adjusted a low-level URL/punycode import, reverting those modules to their standard upstream behavior.

@coderabbitai

coderabbitai Bot commented Apr 5, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ea28dba-2665-4c6e-8110-c23582843249

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 97da5f3 and 972766c.

β›” Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
πŸ“’ Files selected for processing (5)
  • package.json
  • patches/tr46+0.0.3.patch
  • patches/whatwg-url+5.0.0.patch
  • src/path-rewriter.ts
  • src/router.ts
πŸ’€ Files with no reviewable changes (2)
  • patches/whatwg-url+5.0.0.patch
  • patches/tr46+0.0.3.patch
βœ… Files skipped from review due to trivial changes (3)
  • src/router.ts
  • package.json
  • src/path-rewriter.ts

πŸ“ Walkthrough

Walkthrough

The diff replaces the is-plain-object dependency with is-plain-obj, updates two TypeScript imports to use the new default import shape, and removes two patch hunks that altered punycode require paths in vendored tr46 and whatwg-url files.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Replaced dependency is-plain-object (^5.0.0) with is-plain-obj (^4.1.0).
Import Refactoring
src/path-rewriter.ts, src/router.ts
Swapped named import { isPlainObject } from is-plain-object for default import isPlainObject from is-plain-obj; runtime checks and logic unchanged.
Removed Patches
patches/tr46+0.0.3.patch, patches/whatwg-url+5.0.0.patch
Removed patch hunks that changed internal require("punycode") to require("punycode/") in vendored tr46 and whatwg-url files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, a swap without a fuss,

New name in package, old import's been dust,
Objects still plain, the checks still sing,
Patches rolled backβ€”everything's spring.

πŸš₯ Pre-merge checks | βœ… 3
βœ… Passed checks (3 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title accurately describes the main change: replacing the is-plain-object dependency with is-plain-obj across package.json and source files.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
πŸ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch is-plain-obj

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls

coveralls commented Apr 5, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 94.012%. remained the same
when pulling 972766c on is-plain-obj
into 3e7d6df on master.

@pkg-pr-new

pkg-pr-new Bot commented Apr 5, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/http-proxy-middleware@1191

commit: 972766c

@chimurai
chimurai merged commit 42fb02e into master Apr 5, 2026
21 checks passed
@chimurai
chimurai deleted the is-plain-obj branch April 5, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants