Skip to content

refactor(types): improve types - #1299

Merged
chimurai merged 1 commit into
masterfrom
refactor-types
Oct 4, 2026
Merged

chimurai merged 1 commit into
masterfrom
refactor-types

Conversation

@chimurai

@chimurai chimurai commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Type Safety
    • Improved TypeScript typing for request bodies, proxy targets, WebSocket event data, and callback errors.
    • Clarified which properties are available in proxy event callbacks.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Review in Change Stack β†’

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

βš™οΈ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb7347d4-2955-44ef-8af8-b2326734097f
πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between cf713ad and 0d0454c.

πŸ“’ Files selected for processing (5)
  • src/handlers/fix-request-body.ts
  • src/plugins/default/logger-plugin.ts
  • src/router.ts
  • src/types.ts
  • test/types.spec.ts
 _______________________________________________________
< Veni, Vidi, VCS: I came, I saw, I version-controlled. >
 -------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
πŸ“ Generate docstrings
  • Commit to this branch
  • Create a new PR
πŸ§ͺ Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot Β· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/http-proxy-middleware@1299

commit: 69b40c7

@coveralls

coveralls commented Oct 4, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 96.364%. remained the same β€” refactor-types into master

@chimurai
chimurai merged commit 4ed80ab into master Oct 4, 2026
25 checks passed
@chimurai
chimurai deleted the refactor-types branch October 4, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants