Skip to content

fix(loggerPlugin): fix logging url with query string - #1307

Merged
chimurai merged 2 commits into
masterfrom
fix-loggerPlugin
Oct 19, 2026
Merged

chimurai merged 2 commits into
masterfrom
fix-loggerPlugin

Conversation

@chimurai

@chimurai chimurai commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

fixes #1306

Summary by CodeRabbit

  • Bug Fixes
    • Fixed logged proxy request and target URLs so query strings are preserved, including when requests contain multiple query parameters.
    • Improved URL handling for paths with encoded characters, leading double slashes, or an explicitly empty query string.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review in Change Stack β†’

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

βš™οΈ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a787be77-6824-46c5-b146-7b3123ca9e46
πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 0e26561 and 27c9f20.

πŸ“’ Files selected for processing: 5
  • CHANGELOG.md
  • src/plugins/default/logger-plugin.ts
  • src/utils/create-url.ts
  • test/e2e/nock.spec.ts
  • test/unit/utils/create-url.spec.ts
+----------------------------------------+
| Your docs say 'TBD'. I'm here to 'Do'. |
+----------------------------------------+
  \
   \   (\__/)
       (β€’γ……β€’)
       / γ€€ γ₯
✨ Finishing Touches
πŸ“ Generate docstrings
  • Commit to this branch
  • Create a new PR
πŸ§ͺ Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix Β· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/http-proxy-middleware@1307

commit: 27c9f20

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 96.833% (+0.5%) from 96.364% β€” fix-loggerPlugin into master

@chimurai
chimurai merged commit 520603b into master Oct 19, 2026
25 of 26 checks passed
@chimurai
chimurai deleted the fix-loggerPlugin branch October 19, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loggerPlugin: query string '?' is escaped as '%3F' in the logged target URL

2 participants