Repository navigation
Fix definitions import of federation-upstream-set parameters - #2536
Merged
Merged
Conversation
|
No issues found. |
kickster97
reviewed
Oct 23, 2026
kickster97
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
POST /api/definitionsfails with 400 "Cast from Array(JSON::Any) to Hash(K, V) failed" when the body contains afederation-upstream-setparameter, so the broker can't import its own export. Queues, exchanges, bindings and policies from the same body are already applied when it fails, which leaves a half-imported state. The code is the same in 2.10.2.What
The parameter import cast every value to a hash before it looked at the component, but a set's value is an array. Only
vhost-limitsandoperator_policyneed a hash, so the cast now happens in those two branches. Other components pass the raw JSON value toParameteras before.An import is still not all-or-nothing across sections (queues and exchanges are applied before parameters are parsed). That's a separate change.