Repository navigation
Closed
Labels
internalRequires support from the Cloudflare PlatformRequires support from the Cloudflare Platform
Description
Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.17.1
What version of Node are you using?
No response
What operating system are you using?
mac, linux
Describe the Bug
It seems like #4179 changed secret:bulk from using the secrets PUT API to script PATCH... this sounds like a good idea, but in practice, it seems to have broken our CI builds without any notice about this in the changelog, or without any explanation given in the CLI output or wrangler.log
I am happy to share more detailed logging output privately if someone is interested.
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
--- 2023-11-22T22:36:22.137Z log
⛅️ wrangler 3.17.1
-------------------
---
--- 2023-11-22T22:36:22.141Z debug
Saving to cache: {"account":{"id":"***","name":""}}
---
--- 2023-11-22T22:36:22.142Z log
🌀 Creating the secrets for the Worker "gg-preview-pr-667-gameserver"
---
--- 2023-11-22T22:36:22.145Z debug
-- START CF API REQUEST: GET https://api.cloudflare.com/client/v4/accounts/***/workers/scripts/gg-preview-pr-667-gameserver/settings
---
--- 2023-11-22T22:36:22.145Z debug
HEADERS: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.145Z debug
INIT: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.145Z debug
-- END CF API REQUEST
---
--- 2023-11-22T22:36:22.557Z debug
-- START CF API RESPONSE: OK 200
---
--- 2023-11-22T22:36:22.557Z debug
HEADERS: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.557Z debug
RESPONSE: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.557Z debug
-- END CF API RESPONSE
---
--- 2023-11-22T22:36:22.558Z debug
-- START CF API REQUEST: PATCH https://api.cloudflare.com/client/v4/accounts/***/workers/scripts/gg-preview-pr-667-gameserver/settings
---
--- 2023-11-22T22:36:22.558Z debug
HEADERS: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.558Z debug
INIT: omitted; set WRANGLER_LOG_SANITIZE=false to include sanitized data
---
--- 2023-11-22T22:36:22.558Z debug
-- END CF API REQUEST
---
Reacted by Barnaby Shearer and Louis Plancher
Metadata
Metadata
Assignees
Labels
internalRequires support from the Cloudflare PlatformRequires support from the Cloudflare Platform

Activity
aroman commentedon Nov 22, 2023
cc @matthewdavidrodgers, @penalosa
penalosa commentedon Nov 22, 2023
Thanks for reporting this! To investigate this a bit more:
aroman commentedon Nov 22, 2023
@penalosa thanks for the quick followup here.
Much to my surprise, the identical secret:bulk command works fine for new workers created from wrangler or the dash, but apparently not the worker created by our CI deployment script. Any idea what could possibly cause this discrepancy?
JSON. And it's worth noting that wrangler is clearly parsing it correctly, since the error message indicates the correct # of secrets.
penalosa commentedon Nov 22, 2023
Interesting! Do you have any other bindings defined on the worker created in CI?
aroman commentedon Nov 22, 2023
yes, a durable object binding
penalosa commentedon Nov 23, 2023
@aroman We've investigated this a bit further, and it looks like this is a bug in Wrangler when uploading secrets using
secret:bulkto a Worker that has a Durable Object attached. Thanks for flagging this!We're working on a fix—in the meantime the workaround is to use Wrangler v3.16
BarnabyShearer commentedon Jan 4, 2024
https://nvd.nist.gov/vuln/detail/CVE-2023-7080 makes the workaround much less appealing; we really need this fixed.
lrapoport-cf commentedon Jan 8, 2024
hi all, to clarify, this is related to internal bugs (internal tickets: WC-1668, WC-1774, and WC-1613). WC-1613 has been addressed and WC-1774 is in progress; WC-1668 is still outstanding. i'll follow up internally to get info regarding timelines.
lrapoport-cf commentedon Jan 23, 2024
i know this issue is now closed, but to be explicit for posterity: the internal tickets have now all been completed 👍