You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Dependencies cannot be installed in version 3.6.0Β #264
I was deploying normally and suddenly my pipeline started to fail, and it just happened to coincide with the release of the new action version (3.6.0).
It fails when trying to install the package.json dependencies throwing an error that it cannot resolve the dependency. The error is thrown on the import line of the code and advises you to mark it as external to fix it, but this sounded strange to me because it was already working this way.
β [ERROR] Could not resolve "@tsndr/cloudflare-worker-jwt"
I can't reproduce dependency installation issues using the new action version 3.6.0 on my repository.
From the logs you linked it looks to me like it may be a package installation issue, I would double check that zod and @tsndr/cloudflare-worker-jwt are both in your package.json and that's you've ran npm install.
Would it be possible for one you to provide me with a reproduction repository that has this issue?
Same issue here. Had an old worker on wrangler version 3.23.0 that I updated to 3.57.1 with wrangler-action@v3. Weird thing was that Github Actions was still using 3.23.0 for a while and then suddenly stopped working when it installed 3.57.1.
+1 that i'm seeing this issue too with multiple packages:
...: ERROR: Could not resolve "@tsndr/cloudflare-worker-jwt"
...: ERROR: Could not resolve "hono/streaming"
...: ERROR: Could not resolve "openai"
...: ERROR: Could not resolve "@anthropic-ai/sdk"
...: ERROR: Could not resolve "postgres"
I would double check that zod and @tsndr/cloudflare-worker-jwt are both in your package.json and that's you've ran npm install
it was working fine a couple days ago, so pretty sure it's not a package issue / npm install issue.
Also can confirm that downgrading to v3.5.0 works:
Oh, I see what happened. Thanks for the screenshots @sakettawde .
In 3.6.0 we released a new feature which would check for an existing wrangler installation, and use it if appropriate.
The code which checks for an existing installation runs npx wrangler --version to determine if wrangler is installed. What I missed was that this command will automatically install the latest version of wrangler if no version is installed π
This means that by accident wrangler-action now always will install the latest wrangler if you don't specify wranglerVersion in the config. This is a breaking change and bug, since we meant for it to keep it's old behavior and install version 3.13.2 by default.
For everyone who's build is now failing, I suspect your codebase has something about it which requires that older version of wrangler, since wrangler deploy fails for you when using version 3.57.1. In order to restore previous behavior, simply pin wranglerVersion to 3.13.2 like this
We ended up reverting #235 in v3.6.1 to prevent breaking changes for users on old versions of wrangler who inadvertently were now using the latest version of wrangler due to not having it specified.
We will look into fixing this in a follow up because it would be fantastic if we could check for an existing wrangler installation, and install it correctly.
Let us know if you're still experiencing these issues after upgrading to v3.6.1
Activity
edgeboy47 commentedon May 23, 2024
+1
Maximo-Guk commentedon May 23, 2024
Hey @tomaco-gojiraf and @edgeboy47 π!
I can't reproduce dependency installation issues using the new action version
3.6.0on my repository.From the logs you linked it looks to me like it may be a package installation issue, I would double check that
zodand@tsndr/cloudflare-worker-jwtare both in yourpackage.jsonand that's you've rannpm install.Would it be possible for one you to provide me with a reproduction repository that has this issue?
Thank you! π
svrnhdl commentedon May 23, 2024
Same issue here. Had an old worker on wrangler version 3.23.0 that I updated to 3.57.1 with wrangler-action@v3. Weird thing was that Github Actions was still using 3.23.0 for a while and then suddenly stopped working when it installed 3.57.1.
downgrading to action version 3.5.0 fixed it.

kchro3 commentedon May 23, 2024
+1 that i'm seeing this issue too with multiple packages:
it was working fine a couple days ago, so pretty sure it's not a package issue / npm install issue.
Also can confirm that downgrading to v3.5.0 works:
AdiRishi commentedon May 24, 2024
A reproduction repository would be very helpful π
I just upgraded three different repos I have to
3.6.0and it's worked everywhere.Also, some context on what
wrangler-actionwas doing when it failed would be good. Here are some of the steps that run.Some questions
sakettawde commentedon May 24, 2024
Adding context since am facing a similar issue.
Absolutely nothing changed in my code. It started failing today.
Issue seen:

Changed my github workflow file by specifying to use v3.5 for wrangler-action as below:

And now it runs as before. Screengrab of logs below:

hiendaovinh commentedon May 24, 2024
I've the same issue. Pinning to v3.5.0 helps for now.
AdiRishi commentedon May 24, 2024
Oh, I see what happened. Thanks for the screenshots @sakettawde .
In
3.6.0we released a new feature which would check for an existing wrangler installation, and use it if appropriate.The code which checks for an existing installation runs
npx wrangler --versionto determine if wrangler is installed. What I missed was that this command will automatically install the latest version of wrangler if no version is installed πThis means that by accident
wrangler-actionnow always will install the latest wrangler if you don't specifywranglerVersionin the config. This is a breaking change and bug, since we meant for it to keep it's old behavior and install version3.13.2by default.For everyone who's build is now failing, I suspect your codebase has something about it which requires that older version of wrangler, since
wrangler deployfails for you when using version3.57.1. In order to restore previous behavior, simply pinwranglerVersionto3.13.2like thisI'll work on making a PR to fix this issue.
Rohan487 commentedon May 24, 2024
+1
Maximo-Guk commentedon May 24, 2024
Hello π
We ended up reverting #235 in
v3.6.1to prevent breaking changes for users on old versions of wrangler who inadvertently were now using the latest version of wrangler due to not having it specified.We will look into fixing this in a follow up because it would be fantastic if we could check for an existing wrangler installation, and install it correctly.
Let us know if you're still experiencing these issues after upgrading to
v3.6.1Thanks!