Repository navigation
Update the bundled BuildClient to the impossible-to-miss sign-in link build - #5936
Conversation
β¦ build Rebuilt from codenameone/BuildClient fix/browser-login-link at 439b5c7 (BuildClient #7) with JDK 8 and that worktree's own maven repo; the 18 client tests pass. The jar's entry list differs from the one it replaces by exactly the three classes the change adds (BrowserLauncher, BrowserLoginPoller$WaitListener, CodeNameOneBuildTask$3). What it changes for a developer: the sign-in link is printed in a separate block as https://cloud.codenameone.com/l/<key>, repeated every 30 s while the tool waits, and the browser is opened through OS fallbacks when Desktop.browse() silently does nothing (WSL, many Linux desktops, IDE-run Maven). 15 of 18 failed sign-ins in the week to 2026-09-30 waited out the full five minutes. Do not merge before BuildCloud #162 is deployed: /l/ is added there. Until then the block's long fallback URL still works. This covers only the bundled copy. Existing installs update through UpdateCodenameOne.jar, which compares CodeNameOneBuildClientJar in https://www.codenameone.com/files/updates/UpdateStatus.properties (currently 207) by string equality, so the hosted jar must be replaced and that key bumped to 208 on download.codenameone.com, or nobody re-downloads. sha256 25b33000e6c08f4117447fe2f62e93d949539f20212e493b8bcf099d8b9ba2ec Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
There was a problem hiding this comment.
π‘ Codex Review
https://github.com/codenameone/CodenameOne/blob/dd03f232c1821e4c82606f87acbb7e95dfd74b59/maven/CodeNameOneBuildClient.jar#L1
Run fallback launchers after a silent Desktop browse
On Linux desktops where Desktop.browse() returns normally but does not open a browserβthe scenario this change specifically targetsβthe bundled BrowserLauncher.open() treats that return as success and exits before trying xdg-open. Consequently the new OS fallback still does not run for silent no-op implementations; it is used only when the Desktop API is unsupported or throws. The launcher needs a way to avoid trusting Desktop.browse() alone in this environment, such as also attempting the platform fallback.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Compared 157 screenshots: 157 matched. Native Android coverage
β Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
|
Compared 193 screenshots: 193 matched. |
Rebuilt from codenameone/BuildClient fix/browser-login-link at f3c29f7 with JDK 8; the 19 client tests pass. Adds CodeNameOneBuildTask$4 (the bounded browser-launch thread). The link is now printed before any launch attempt, Linux/WSL try the platform opener before Desktop.browse(), and WSL uses rundll32.exe instead of cmd.exe so the URL's percent escapes survive. This supersedes the sha256 in the PR description. Current jar: sha256 c7a30e7f66ecf5aac872deb9589e1e6fa2ab38389cf35273583e83d1f9556dc9 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with π. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
β Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
Compared 150 screenshots: 150 matched. |
|
Compared 166 screenshots: 166 matched. Benchmark Results
Detailed Performance Metrics
ParparVM vs HotSpot (JDK 25): macOS arm64Runner CPU: Apple M1 (Virtual) (baseline Ratios are ParparVM / JDK 25: below 1.00x ParparVM is faster (time) or smaller (RAM). Median of 5 interleaved, paired rounds; every run's output was verified. A regression is a ratio more than 15% (time) / 15% (RAM) above its baseline in
Result: no regression |
|
Compared 223 screenshots: 223 matched. |
No description provided.