Skip to content

Update the bundled BuildClient to the impossible-to-miss sign-in link build - #5936

Merged
shai-almog merged 2 commits into
masterfrom
update-buildclient-login-link
Oct 2, 2026
Merged

shai-almog merged 2 commits into
masterfrom
update-buildclient-login-link

Conversation

@shai-almog

@shai-almog shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

… build

Rebuilt from codenameone/BuildClient fix/browser-login-link at 439b5c7
(BuildClient #7) with JDK 8 and that worktree's own maven repo; the 18 client
tests pass. The jar's entry list differs from the one it replaces by exactly
the three classes the change adds (BrowserLauncher,
BrowserLoginPoller$WaitListener, CodeNameOneBuildTask$3).

What it changes for a developer: the sign-in link is printed in a separate
block as https://cloud.codenameone.com/l/<key>, repeated every 30 s while the
tool waits, and the browser is opened through OS fallbacks when
Desktop.browse() silently does nothing (WSL, many Linux desktops, IDE-run
Maven). 15 of 18 failed sign-ins in the week to 2026-09-30 waited out the full
five minutes.

Do not merge before BuildCloud #162 is deployed: /l/ is added there. Until
then the block's long fallback URL still works.

This covers only the bundled copy. Existing installs update through
UpdateCodenameOne.jar, which compares CodeNameOneBuildClientJar in
https://www.codenameone.com/files/updates/UpdateStatus.properties (currently
207) by string equality, so the hosted jar must be replaced and that key
bumped to 208 on download.codenameone.com, or nobody re-downloads.

sha256 25b33000e6c08f4117447fe2f62e93d949539f20212e493b8bcf099d8b9ba2ec

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@shai-almog
shai-almog marked this pull request as ready for review October 2, 2026 08:23
@shai-almog

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-10-02T08:56:58.802398Z 75bb456 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

https://github.com/codenameone/CodenameOne/blob/dd03f232c1821e4c82606f87acbb7e95dfd74b59/maven/CodeNameOneBuildClient.jar#L1
P2 Badge Run fallback launchers after a silent Desktop browse

On Linux desktops where Desktop.browse() returns normally but does not open a browserβ€”the scenario this change specifically targetsβ€”the bundled BrowserLauncher.open() treats that return as success and exits before trying xdg-open. Consequently the new OS fallback still does not run for silent no-op implementations; it is used only when the Desktop API is unsupported or throws. The launcher needs a way to avoid trusting Desktop.browse() alone in this environment, such as also attempting the platform fallback.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shai-almog

shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 157 screenshots: 157 matched.

Native Android coverage

  • πŸ“Š Line coverage: 9.37% (9335/99611 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 9.10% (47873/525841), branch 3.61% (1797/49819), complexity 3.58% (1902/53096), method 5.53% (1544/27918), class 11.06% (414/3742)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6367 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.ClassReader – 0.00% (0/1524 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1187 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.MethodWriter – 0.00% (0/922 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/736 lines covered)
      • com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
      • okio.okio.Buffer – 0.00% (0/687 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/625 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.Frame – 0.00% (0/570 lines covered)

βœ… Native Android screenshot tests passed.

Native Android coverage

  • πŸ“Š Line coverage: 9.37% (9335/99611 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 9.10% (47873/525841), branch 3.61% (1797/49819), complexity 3.58% (1902/53096), method 5.53% (1544/27918), class 11.06% (414/3742)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6367 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.ClassReader – 0.00% (0/1524 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1187 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.MethodWriter – 0.00% (0/922 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/736 lines covered)
      • com.google.common.cache.com.google.common.cache.LocalCache$Segment – 0.00% (0/726 lines covered)
      • okio.okio.Buffer – 0.00% (0/687 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/625 lines covered)
      • org.jacoco.agent.rt.internal_0e20598.asm.org.jacoco.agent.rt.internal_0e20598.asm.Frame – 0.00% (0/570 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
SIMD kernel backend scalar fallback (no native SIMD)
SIMD int-add (64K x300) java 185ms / native 299ms = 0.6x speedup
SIMD float-mul (64K x300) java 98ms / native 111ms = 0.8x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path gated to scalar (CPU autovectorizes scalar; explicit SIMD not beneficial here)
Base64 CN1 encode 89.000 ms
Base64 CN1 decode 84.000 ms
Base64 native encode 380.000 ms
Base64 encode ratio (CN1/native) 0.234x (76.6% faster)
Base64 native decode 280.000 ms
Base64 decode ratio (CN1/native) 0.300x (70.0% faster)
Image encode benchmark status skipped (SIMD unsupported)

@shai-almog

shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 193 screenshots: 193 matched.
βœ… JavaScript-port screenshot tests passed.

Rebuilt from codenameone/BuildClient fix/browser-login-link at f3c29f7 with
JDK 8; the 19 client tests pass. Adds CodeNameOneBuildTask$4 (the bounded
browser-launch thread). The link is now printed before any launch attempt,
Linux/WSL try the platform opener before Desktop.browse(), and WSL uses
rundll32.exe instead of cmd.exe so the URL's percent escapes survive.

This supersedes the sha256 in the PR description. Current jar:
sha256 c7a30e7f66ecf5aac872deb9589e1e6fa2ab38389cf35273583e83d1f9556dc9

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@shai-almog

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 75bb456aed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

βœ… Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • βœ… ByteCodeTranslator: 0 findings (no issues)
    • βœ… android: 0 findings (no issues)
    • βœ… backend: 0 findings (no issues)
    • βœ… build-engine: 0 findings (no issues)
    • βœ… build-hint-catalog: 0 findings (no issues)
    • βœ… build-hint-tools: 0 findings (no issues)
    • βœ… codenameone-gradle-plugin: 0 findings (no issues)
    • βœ… codenameone-maven-plugin: 0 findings (no issues)
    • βœ… core-unittests: 0 findings (no issues)
    • βœ… ios: 0 findings (no issues)
    • βœ… project-model: 0 findings (no issues)
  • βœ… PMD: 0 findings (no issues) [Report archive]
  • βœ… Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog

shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 150 screenshots: 150 matched.
βœ… Native Apple TV (tvOS, Metal) screenshot tests passed.

@shai-almog

shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 166 screenshots: 166 matched.
βœ… Native Mac screenshot tests passed.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 260 seconds

Detailed Performance Metrics

Metric Duration
SIMD kernel backend SSE2 (x64) / NEON (arm64) native kernels
SIMD int-add (64K x300) java 53ms / native 3ms = 17.6x speedup
SIMD float-mul (64K x300) java 56ms / native 3ms = 18.6x speedup
SIMD kernel correctness PASS (native result == scalar reference)
Base64 native bridge unavailable (CN1 + SIMD + image benchmarks only)
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 SIMD byte path active (NEON-accelerated)
Base64 CN1 encode 54.000 ms
Base64 CN1 decode 54.000 ms
Image encode benchmark iterations 100
Image createMask (SIMD off) 11.000 ms
Image createMask (SIMD on) 6.000 ms
Image createMask ratio (SIMD on/off) 0.545x (45.5% faster)
Image applyMask (SIMD off) 70.000 ms
Image applyMask (SIMD on) 66.000 ms
Image applyMask ratio (SIMD on/off) 0.943x (5.7% faster)
Image modifyAlpha (SIMD off) 49.000 ms
Image modifyAlpha (SIMD on) 52.000 ms
Image modifyAlpha ratio (SIMD on/off) 1.061x (6.1% slower)
Image modifyAlpha removeColor (SIMD off) 54.000 ms
Image modifyAlpha removeColor (SIMD on) 58.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 1.074x (7.4% slower)

ParparVM vs HotSpot (JDK 25): macOS arm64

Runner CPU: Apple M1 (Virtual) (baseline macos-arm64)

Ratios are ParparVM / JDK 25: below 1.00x ParparVM is faster (time) or smaller (RAM). Median of 5 interleaved, paired rounds; every run's output was verified. A regression is a ratio more than 15% (time) / 15% (RAM) above its baseline in vm/selfhost/perf-baseline.json (more, for a row whose calibration runs were noisier; the file records it), and for RAM also more than 0.05x above it in absolute terms. Both run unpinned on all of the runner's CPUs, with their own default thread counts.

Benchmark Cores Time RAM Status
hello (HelloCodenameOne) 3 0.87x (base 0.96x, -9.2%) 1.33x (base 1.34x, -1.0%) ok
translator (self) 3 0.54x (base 0.54x, -0.4%) 0.78x (base 0.74x, +5.4%) ok
intArithmetic 3 1.05x (base 1.03x, +1.6%) 0.12x (base 0.12x, +0.3%) ok
longArithmetic 3 1.03x (base 1.03x, +0.4%) 0.11x (base 0.11x, -2.2%) ok
mathTranscendental 3 0.98x (base 1.01x, -2.3%) 0.12x (base 0.12x, -1.0%) ok
arraySequential 3 0.42x (base 0.42x, +0.3%) 0.53x (base 0.53x, -0.1%) ok
arrayRandom 3 0.98x (base 0.99x, -1.0%) 0.32x (base 0.32x, -0.2%) ok
objectAllocation 3 3.63x (base 3.70x, -1.7%) 0.40x (base 0.48x, -16.9%) ok
valueEscape 3 0.50x (base 0.51x, -1.4%) 0.08x (base 0.09x, -6.5%) ok
hashMapChurn 3 1.07x (base 1.18x, -9.2%) 0.07x (base 0.07x, +4.9%) ok
stringBuilding 3 0.89x (base 0.84x, +5.4%) 0.45x (base 0.54x, -15.8%) better than baseline
recursion 3 1.22x (base 1.24x, -0.9%) 0.12x (base 0.12x, -0.9%) ok
quicksort 3 0.99x (base 1.01x, -2.6%) 0.11x (base 0.11x, -0.1%) ok

Result: no regression

@shai-almog

shai-almog commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Compared 223 screenshots: 223 matched.
βœ… Native Apple Watch (watchOS, Core Graphics) screenshot tests passed.

@shai-almog
shai-almog merged commit 37271f5 into master Oct 2, 2026
@shai-almog
shai-almog deleted the update-buildclient-login-link branch October 2, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant