Skip to content

Fix legacy library downloads in Settings - #5981

Merged
shai-almog merged 1 commit into
masterfrom
fix/settings-library-downloads
Oct 10, 2026
Merged

shai-almog merged 1 commit into
masterfrom
fix/settings-library-downloads

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

Settings constructs legacy library URLs such as /files/CN1JSON.cn1lib, which return 404. The catalog artifacts are served through /files/cn1libs/. Correct the installer URL and add a single-segment .cn1lib compatibility redirect so released Settings versions can download libraries after the website deploys.

The compatibility rule follows the existing download-directory rules and leaves their destinations unchanged. Regression cases cover JSON and Bouncy Castle, both URL forms, query strings, and all seven existing download-directory routes.

Validation:

  • Reproduced the flat-path 404s before the fix in Wrangler 4.129.0 Pages runtime.
  • Passed 26 local Pages runtime checks without Functions, matching the current deployment shape; includes existing literal downloads, directory precedence, a local static asset, and unrelated 404s.
  • Followed both JSON URLs through the patched local runtime to HTTP 200 and verified identical valid 30,711-byte archives.
  • Passed all four redirect-order tests and git diff --check.

This fixes the confirmed download failure; the reported Settings UI freeze has not been reproduced. The separate fallback-function deployment concern is outside this change.

Discussion: #5978

@shai-almog

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-10-10T03:10:55.231637Z a0101c4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a0101c4279

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare Preview

@shai-almog
shai-almog merged commit 8cc51a3 into master Oct 10, 2026
@shai-almog
shai-almog deleted the fix/settings-library-downloads branch October 10, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant