Repository navigation
[tests] Add more matrix multiply tests - #594
Merged
lloydk merged 6 commits intoJan 11, 2025
Merged
Conversation
β Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
I'll be adding a comment about my understanding of 'row-major ordered & pre-multiplication' vs 'column-major ordered & post-multiplication' to the broader discussion thread in the next few days. |
Contributor
Author
|
It's been much longer than a few days, but I've added some details for future consideration on 'row-major ordered & pre-multiplication' vs 'column-major ordered & post-multiplication' to the broader discussion thread. |
lloydk
approved these changes
Jan 11, 2025
lloydk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, sorry for the delay.
Contributor
Author
|
No worries, and I'll add a pull request with changes to the implementation that will pass these tests in the next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more tests for matrix multiply.
And utility functions so additional tests for
multiply_v3_matrix3x3will be easy to add.The new tests are skipped, because they are provisional, and I just want to highlight them.
The expected results are still visible in the HTML runner version of the tests.
If these tests seem reasonable for generic matrix multiplication, I'd be happy to make minimal changes to
multiplyMatricesthat would pass these tests in a future pull request.I have some broader questions around how matrix multiplication should work for
color.js, but I started a discussion thread to have that broader conversation.