Skip to content

[tests] Add more matrix multiply tests - #594

Merged
lloydk merged 6 commits into
color-js:mainfrom
epsilonError:tests/add-more-matrix-multiply-tests
Jan 11, 2025
Merged

lloydk merged 6 commits into
color-js:mainfrom
epsilonError:tests/add-more-matrix-multiply-tests

Conversation

@epsilonError

Copy link
Copy Markdown
Contributor

Added more tests for matrix multiply.
And utility functions so additional tests for multiply_v3_matrix3x3 will be easy to add.

The new tests are skipped, because they are provisional, and I just want to highlight them.
The expected results are still visible in the HTML runner version of the tests.

If these tests seem reasonable for generic matrix multiplication, I'd be happy to make minimal changes to multiplyMatrices that would pass these tests in a future pull request.

I have some broader questions around how matrix multiplication should work for color.js, but I started a discussion thread to have that broader conversation.

@netlify

netlify Bot commented Sep 6, 2024 •

Copy link
Copy Markdown

βœ… Deploy Preview for colorjs ready!

Name Link
πŸ”¨ Latest commit 38e53b9
πŸ” Latest deploy log https://app.netlify.com/sites/colorjs/deploys/66da61f0c7b2730008cfa862
😎 Deploy Preview https://deploy-preview-594--colorjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@epsilonError

Copy link
Copy Markdown
Contributor Author

I'll be adding a comment about my understanding of 'row-major ordered & pre-multiplication' vs 'column-major ordered & post-multiplication' to the broader discussion thread in the next few days.

@LeaVerou
LeaVerou requested a review from lloydk December 26, 2024 17:26
@epsilonError

Copy link
Copy Markdown
Contributor Author

It's been much longer than a few days, but I've added some details for future consideration on 'row-major ordered & pre-multiplication' vs 'column-major ordered & post-multiplication' to the broader discussion thread.

@lloydk lloydk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

@lloydk
lloydk merged commit ffa9c3f into color-js:main Jan 11, 2025
@epsilonError
epsilonError deleted the tests/add-more-matrix-multiply-tests branch January 12, 2025 04:21
@epsilonError

Copy link
Copy Markdown
Contributor Author

No worries, and I'll add a pull request with changes to the implementation that will pass these tests in the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants