Repository navigation
[types] Add types for spaces and src exports - #668
Merged
Merged
Conversation
This commit doesn't touch the exports for `dist`, it just fixes the
types for `spaces` and `src`.
Example:
```typescript
import { toPrecision } from "colorjs.io/src/util.js";
```
Is now typed properly.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LeaVerou
approved these changes
Aug 10, 2025
LeaVerou
left a comment
Member
There was a problem hiding this comment.
Ooh nice, thanks!
You'd expect TypeScript would be smart enough to figure this out (at least for src) but nooope…
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666
This commit doesn't touch the exports for
dist, it just fixes the types forspacesandsrc. I only specified theimportproperty for each of the two exports, since the files use ESM exports and wouldn't work withrequire.Example (from #666):
Is now typed properly.