Skip to content

Make run commands exclusive - #6220

Merged
lihaoyi merged 7 commits into
com-lihaoyi:mainfrom
lihaoyi:exclusive-run
Nov 20, 2025
Merged

lihaoyi merged 7 commits into
com-lihaoyi:mainfrom
lihaoyi:exclusive-run

Conversation

@lihaoyi

@lihaoyi lihaoyi commented Nov 19, 2025 •

Copy link
Copy Markdown
Member

As part of this, loosened up handling of exclusive commands such that downstream commands not marked as exclusive are automatically treated as such. This is to avoid breakage of anyone who is currently defining an override def run() = Task.Command{ super.run()() }, which would otherwise start failing since super.run has suddenly become exclusive. Only downstream commands are treated as such - non-command tasks are still an error - and I expect this is an uncommon enough scenario that it won't affect much

Also cleaned up the messiness in BspRunModule and tweaked bspRun to avoid the Task.Anon that would interfere with exclusivity

Fix #5208

@lihaoyi
lihaoyi merged commit 487e481 into com-lihaoyi:main Nov 20, 2025
@lefou lefou added this to the 1.1.0 milestone Nov 20, 2025
lihaoyi added a commit that referenced this pull request Feb 16, 2026
We already made the task exclusive in
#6220, so might as well make the
subprocess interactive so things like using `.run` on terminal
applications works without fiddling.

Tested manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conside exclusive-mode by default for RunModule.run.

2 participants