Skip to content

Fix java error formatting in the presence of tabs - #6810

Merged
lihaoyi merged 23 commits into
com-lihaoyi:mainfrom
lihaoyi:java-tabs-errors
Feb 9, 2026
Merged

lihaoyi merged 23 commits into
com-lihaoyi:mainfrom
lihaoyi:java-tabs-errors

Conversation

@lihaoyi

@lihaoyi lihaoyi commented Feb 9, 2026 •

Copy link
Copy Markdown
Member

Fixes #6809 by reverse engineering Java error message source column locations from the reported locations, which have every tab character multiplied by 8. Also fixes some issues in the Scala error message source column which also processed tabs wrongly (e.g. by inserting accidental whitespaces before them)

Covered by unit tests. Also moved a bunch of adjacent integration/failure tests to unit tests to reduce CI costs

@lihaoyi
lihaoyi merged commit 11b3e88 into com-lihaoyi:main Feb 9, 2026
8 checks passed
@lefou lefou added this to the 1.1.3 milestone Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs in Java lead to incorrect error position

2 participants