Repository navigation
Ensure local test repo has precedence over local Ivy 2 repo in ITs - #6819
Merged
lihaoyi merged 4 commits intoFeb 13, 2026
Merged
Conversation
Seems POM files were left over at the root of local repos, like ```text $ ls out/libs/javalib/worker/publishLocalTestRepo.dest com/ mill-libs-javalib-worker_3-SNAPSHOT.pom $ ls out/dist/raw/localRepo.dest com mill-contrib-artifactory_3-SNAPSHOT.pom mill-contrib-buildinfo_3-SNAPSHOT.pom ... ```
And has precedence over other repos
lihaoyi
reviewed
Feb 12, 2026
| Seq("MILL_LOCAL_TEST_REPO" -> localRepo().path.toString) | ||
| val repos = Seq(localRepo().path.toNIO.toUri.toASCIIString) ++ | ||
| Seq(Task.env.getOrElse("COURSIER_REPOSITORIES", "ivy2Local|central")) | ||
| Seq("COURSIER_REPOSITORIES" -> repos.mkString("|")) |
Member
There was a problem hiding this comment.
Is there a reason to join/split by | to later join by :, rather than passing them joined by : to begin with?
Collaborator
Author
There was a problem hiding this comment.
You mean, in CoursierClient.resolveMillDaemon? We can change the separator there too.
| is used because it's the separator that COURSIER_REPOSITORIES uses (so that it's fine with URLs).
Collaborator
Author
There was a problem hiding this comment.
Just changed that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the need of
MILL_LOCAL_TEST_REPOandMILL_USER_TEST_REPOfrom #5514, and manages those repos solely via theCOURSIER_REPOSITORIESenvironment variable. That way, the repositories frommill-repositoriesof #6713 automatically get precedence over the former repos.This addresses issues I've been seeing locally, where some artifacts under
~/.ivy2/localwere being used by the JvmWorker, while they shouldn't.