Repository navigation
Android koin example - #6833
Android koin example#6833
Conversation
|
Thanks @ABeesettiPaleBlue . Keep in mind that once it works, the example should go to third party, you can find examples here and here |
|
Yes the roboelectric thing is an open issue, hopefully we should resolve it soon. @souvlakias can you test/review this? Also there's a formatting issue @ABeesettiPaleBlue to check the formatting and auto fix locally you can use
|
Co-authored-by: Vasilis Nicolaou <vasilis.nicolaou@vaslabs.io>
|
@souvlakias just fixed the robolectric stuff, so let's wait a bit and we can update this PR before merging |
|
Regarding the roboelectric tests, after #6841 gets merged, the |
Closes #6620 This adds to the support for the `isIncludeAndroidResources` that was introduced in #6638, by generating the `com/android/tools/test_config.properties` file as described [here (agp docs)](https://developer.android.com/reference/tools/gradle-api/8.3/null/com/android/build/api/dsl/UnitTestOptions#getIsIncludeAndroidResources()). This also makes roboelectric unit tests work (Ref: [jetcaster.wear](https://github.com/vaslabs-ltd/compose-samples-with-mill/blob/main/Jetcaster/package.mill#L442) and the [koin example](#6833))
|
@souvlakias, I've set the property |
Can you push the change in the build.mill so we can reproduce |
|
let's merge it and we can follow up with another PR for the pipeline setup cc: @souvlakias @lihaoyi |
I forgot to rebuild, It's working now after the rebuild |
|
@ABeesettiPaleBlue feel free to give feedback and ideas in the discussions here , we are interested to see your point of view |
|
To test the example you can run
|
vaslabs
left a comment
There was a problem hiding this comment.
Some minor changes to get it ready after robolectric fix
I thought the comments are to let the users know how to run the example app, but they double as a test too. Pretty cool. |
### Motivation - Document the support of Robolectric tests - Have them in CI ### Adds - The Koin example (#6833) (only it's Robolectric unit tests) to the CI - A relevant doc page

Added koin/examples/androidx-samples to thirdparty examples (Closes #6652)