Skip to content

ExampleTester: Support commands with # - #6834

Merged
lihaoyi merged 3 commits into
com-lihaoyi:mainfrom
vaslabs-ltd:exampletester-support-commands-with-#
Feb 16, 2026
Merged

lihaoyi merged 3 commits into
com-lihaoyi:mainfrom
vaslabs-ltd:exampletester-support-commands-with-#

Conversation

@souvlakias

@souvlakias souvlakias commented Feb 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #6621

This makes the ExampleTester expect a space character before # for the following to be a start of a comment
(this also seems like the default shell behavior too)

Also adds expected outputs for the tests of android helloworld examples

/** Usage

> ./mill show app.it -e class 'com.helloworld.app.ExampleInstrumentedTest#useAppContext'
..."status": "Success"...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add for each output (here and above) the actual out that proves the test run obeys the command filter?

@souvlakias
souvlakias marked this pull request as ready for review February 16, 2026 12:48
@lihaoyi
lihaoyi merged commit a3fba10 into com-lihaoyi:main Feb 16, 2026
45 checks passed
@lefou lefou added this to the 1.1.3 milestone Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example Test Suite: command containing '#' is not working

4 participants