Repository navigation
Handle relative path in dottyStyleMessage. - #6851
Merged
Merged
Conversation
PapyChacal
force-pushed
the
emilien/relpath
branch
2 times, most recently
from
February 18, 2026 17:29
2874c9f to
53d0048
Compare
PapyChacal
force-pushed
the
emilien/relpath
branch
from
February 18, 2026 17:35
53d0048 to
6c60ea6
Compare
Comment on lines
+85
to
+90
| val absPath = os.FilePath(path) match { | ||
| case abs: os.Path => abs | ||
| // Assume relative paths are relative to the current workspaceRoot | ||
| case rel: os.RelPath => workspaceRoot / rel | ||
| case sub: os.SubPath => workspaceRoot / sub | ||
| } |
Collaborator
There was a problem hiding this comment.
Same as this?
Suggested change
| val absPath = os.FilePath(path) match { | |
| case abs: os.Path => abs | |
| // Assume relative paths are relative to the current workspaceRoot | |
| case rel: os.RelPath => workspaceRoot / rel | |
| case sub: os.SubPath => workspaceRoot / sub | |
| } | |
| val absPath = os.Path(path, workspaceRoot) |
lihaoyi
pushed a commit
that referenced
this pull request
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed as potential solution to my own issue:
In a nutshell, this line is crashing whole builds for simple warnings, in some very specific cases. I figured that maybe the absolute path expectation was just arbitrary?