Skip to content

Handle relative path in dottyStyleMessage. - #6851

Merged
lihaoyi merged 2 commits into
com-lihaoyi:mainfrom
PapyChacal:emilien/relpath
Feb 20, 2026
Merged

lihaoyi merged 2 commits into
com-lihaoyi:mainfrom
PapyChacal:emilien/relpath

Conversation

@PapyChacal

@PapyChacal PapyChacal commented Feb 18, 2026 •

Copy link
Copy Markdown
Contributor

Proposed as potential solution to my own issue:

@PapyChacal
PapyChacal force-pushed the emilien/relpath branch 2 times, most recently from 2874c9f to 53d0048 Compare February 18, 2026 17:29
@PapyChacal
PapyChacal marked this pull request as ready for review February 19, 2026 12:34
@lihaoyi
lihaoyi merged commit 89e66e1 into com-lihaoyi:main Feb 20, 2026
44 of 45 checks passed
@lefou lefou added this to the 1.1.3 milestone Feb 20, 2026
Comment on lines +85 to +90
val absPath = os.FilePath(path) match {
case abs: os.Path => abs
// Assume relative paths are relative to the current workspaceRoot
case rel: os.RelPath => workspaceRoot / rel
case sub: os.SubPath => workspaceRoot / sub
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as this?

Suggested change
val absPath = os.FilePath(path) match {
case abs: os.Path => abs
// Assume relative paths are relative to the current workspaceRoot
case rel: os.RelPath => workspaceRoot / rel
case sub: os.SubPath => workspaceRoot / sub
}
val absPath = os.Path(path, workspaceRoot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants