Skip to content

Move visualize to a separate worker - #6852

Merged
lihaoyi merged 10 commits into
com-lihaoyi:mainfrom
re-thc:start
Feb 20, 2026
Merged

lihaoyi merged 10 commits into
com-lihaoyi:mainfrom
re-thc:start

Conversation

@re-thc

@re-thc re-thc commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Was looking into cold start performance and visualize downloads a lot of libs before anything happens (and likely isn't used in a lot of paths).

Visualize needs its own dedicated thread and queues etc also.

This moves it to a worker.

@re-thc
re-thc marked this pull request as draft February 18, 2026 22:00
@re-thc
re-thc marked this pull request as ready for review February 18, 2026 23:19
@lihaoyi

lihaoyi commented Feb 19, 2026

Copy link
Copy Markdown
Member

Looks great, just need to regenerate the golden test files and I'll merge it

@re-thc

re-thc commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@lihaoyi I've found this confusing with what happens with scala3_library and so I'm not sure if I should have those changed or not. I've generated and ran it locally lots of times and tried to fix it.

I suspect the issue is coursier/cache-action and the selective tests. The what the cache returns across CI runs and how that impacts what GenIdea gets picked up is the issue.

What would be the fix?

@lihaoyi

lihaoyi commented Feb 19, 2026

Copy link
Copy Markdown
Member

@re-thc I have no idea what you are asking

}
}

// TODO: Remove bin-compat shim in Mill 2.x

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you preserve this TODO, otherwise we risk to overlook to remove this deprecation again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@re-thc

re-thc commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@lihaoyi see if this fix is acceptable for CI

@lihaoyi
lihaoyi merged commit a394690 into com-lihaoyi:main Feb 20, 2026
35 checks passed
@lihaoyi

lihaoyi commented Feb 20, 2026

Copy link
Copy Markdown
Member

Thanks @re-thc !

@lefou lefou added this to the 1.1.3 milestone Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants