Repository navigation
Move visualize to a separate worker - #6852
Merged
Merged
Conversation
re-thc
marked this pull request as draft
February 18, 2026 22:00
re-thc
marked this pull request as ready for review
February 18, 2026 23:19
Member
|
Looks great, just need to regenerate the golden test files and I'll merge it |
Contributor
Author
|
@lihaoyi I've found this confusing with what happens with scala3_library and so I'm not sure if I should have those changed or not. I've generated and ran it locally lots of times and tried to fix it. I suspect the issue is coursier/cache-action and the selective tests. The what the cache returns across CI runs and how that impacts what GenIdea gets picked up is the issue. What would be the fix? |
Member
|
@re-thc I have no idea what you are asking |
lefou
reviewed
Feb 19, 2026
| } | ||
| } | ||
|
|
||
| // TODO: Remove bin-compat shim in Mill 2.x |
Member
There was a problem hiding this comment.
Can you preserve this TODO, otherwise we risk to overlook to remove this deprecation again.
Contributor
Author
|
@lihaoyi see if this fix is acceptable for CI |
Member
|
Thanks @re-thc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking into cold start performance and visualize downloads a lot of libs before anything happens (and likely isn't used in a lot of paths).
Visualize needs its own dedicated thread and queues etc also.
This moves it to a worker.