Repository navigation
Quarkus: Add todo example - #6858
Merged
Merged
Conversation
Contributor
|
Looks ready to me |
vaslabs
approved these changes
Feb 21, 2026
souvlakias
marked this pull request as ready for review
February 21, 2026 09:44
vaslabs
reviewed
Feb 21, 2026
| @Path("/todos") | ||
| public class Todos { | ||
|
|
||
| private static final List<Todo> list = new CopyOnWriteArrayList<>(); |
Contributor
There was a problem hiding this comment.
Just realised the other examples have a database model, we can do this here as well
Contributor
There was a problem hiding this comment.
Alternatively we can follow up with another PR since this already contains fixes for reflection and resources
vaslabs
reviewed
Feb 21, 2026
| public class TodosTest { | ||
|
|
||
| @Test | ||
| public void testTodoPage() { |
Contributor
There was a problem hiding this comment.
Should also do a get empty -> post -> get what we posted test
souvlakias
marked this pull request as draft
February 21, 2026 11:25
vaslabs
suggested changes
Feb 21, 2026
vaslabs
left a comment
Contributor
There was a problem hiding this comment.
- database (H2/in memory) + test enhancements
vaslabs
reviewed
Feb 22, 2026
vaslabs
reviewed
Feb 22, 2026
Contributor
|
looks reasonable well made I think, let's just add a few pointers and should be ready + add it to the mill java web docs |
vaslabs
reviewed
Feb 22, 2026
add urls make tests Task a constant
and a small description
vaslabs
approved these changes
Feb 22, 2026
souvlakias
marked this pull request as ready for review
February 22, 2026 12:38
vaslabs
reviewed
Feb 23, 2026
Contributor
|
I think the failure is flakiness |
Contributor
|
This is ready for review/merge @lihaoyi , includes also fixes for handling resources and can close the quarkus ticket linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3549
Adds
quarkus-quteandquarkus-rest-quteChanges to QuarkusModule
-parametersoption tomadndatoryJavacOptionswhich is needed by qute to map method parameter names to template variables.quarkusBuildResourcesto now include allresources()instead of being a placeholder. (This was needed for tests to work)pow
