Skip to content

Quarkus: Add todo example - #6858

Merged
lihaoyi merged 10 commits into
com-lihaoyi:mainfrom
vaslabs-ltd:quarkus-todo-example
Feb 27, 2026
Merged

lihaoyi merged 10 commits into
com-lihaoyi:mainfrom
vaslabs-ltd:quarkus-todo-example

Conversation

@souvlakias

@souvlakias souvlakias commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

Addresses #3549

Adds

Changes to QuarkusModule

  • Add -parameters option to madndatoryJavacOptions which is needed by qute to map method parameter names to template variables.
  • Makes quarkusBuildResources to now include all resources() instead of being a placeholder. (This was needed for tests to work)

pow
image

@vaslabs

vaslabs commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Looks ready to me

@souvlakias
souvlakias marked this pull request as ready for review February 21, 2026 09:44
@Path("/todos")
public class Todos {

private static final List<Todo> list = new CopyOnWriteArrayList<>();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised the other examples have a database model, we can do this here as well

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we can follow up with another PR since this already contains fixes for reflection and resources

public class TodosTest {

@Test
public void testTodoPage() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also do a get empty -> post -> get what we posted test

@souvlakias
souvlakias marked this pull request as draft February 21, 2026 11:25

@vaslabs vaslabs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • database (H2/in memory) + test enhancements

@vaslabs

vaslabs commented Feb 22, 2026 •

Copy link
Copy Markdown
Contributor

looks reasonable well made I think, let's just add a few pointers and should be ready

+ add it to the mill java web docs

add urls
make tests Task a constant
and a small description
@souvlakias
souvlakias marked this pull request as ready for review February 22, 2026 12:38
imports were separated by comments
@vaslabs

vaslabs commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

I think the failure is flakiness

@vaslabs

vaslabs commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

This is ready for review/merge @lihaoyi , includes also fixes for handling resources and can close the quarkus ticket linked

@lihaoyi
lihaoyi merged commit 92b92e5 into com-lihaoyi:main Feb 27, 2026
35 of 36 checks passed
@lefou lefou added this to the 1.1.3 milestone Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants