Repository navigation
Avoid using CoursierModule#mapDependencies - #6873
Merged
alexarchambault merged 4 commits intoFeb 23, 2026
Merged
Conversation
And stop allowing users to customize the Scala organization via it. Seems this was mostly useful when typelevel had its own compiler fork, but not much beyond that.
It makes it harder to make sense of resolutions when this parameter is being used, while resolutionParams is much easier to inspect
alexarchambault
marked this pull request as ready for review
February 23, 2026 17:19
lihaoyi
approved these changes
Feb 23, 2026
Member
|
Considering, that this will break all user modules that rely on |
Collaborator
Author
|
@lefou That's not a breaking change, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around an issue I raised in the past.
CoursierModule#mapDependenciesmakes dependency resolution less "standard": resolutions relying on it can't be easily done with the coursier CLI or from other build tools for comparison.Mill using it by default can surprise users trying to make sense of some resolutions, and debug them outside of Mill. This PR makes Mill stop relying on it by default, and makes it use
CoursierModule#resolutionParamsinstead.Only one use of
mapDependenciescan't be handled withresolutionParamsfor now: using a custom Scala organization. AFAIK, this was only useful in the past with the Typelevel fork of the Scala compiler. This compiler fork has been discontinued for a while, and I'm not sure anyone needs to customize the scala organization. So this PR simply drops the ability to customize it.Lastly, this PR makes sure test modules inherit
resolutionParamsfrom their main module