Repository navigation
Allow users to discover tests classes via zinc - #6901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to enable test class discovery using the zinc analysis file, rather than by inspecting test class files.
This is useful when using Scala.js' junit4 compatibility library. Tests are annotated with
@Test, but these annotations are nowhere to be found in the resulting class files, so that Mill's current test class discovery misses those. sbt finds those on the other hand, as it finds test classes using the zinc analysis file.This PR allows users to do the same from Mill, by setting
discoverTestsWithZincto true in Scala test modules. This allows Mill to run Scala.js junit4 test suites, as shown in the tests added in this PR.This is not enabled by default, as this is only useful in a very specific case (use of junit4 in Scala.js tests), and the current test discovery mechanism seems to work fine aside from that very specific case.