Repository navigation
Better compiler error when a build package and a task clash - #6903
Merged
lihaoyi merged 2 commits intoMar 5, 2026
Merged
Conversation
To more easily make sense of generated sources
alexarchambault
marked this pull request as ready for review
March 5, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very slightly changes the way Mill refers to other packages in the build, in the header it adds to
*.millfiles, in order to get better compilation errors in some cases.Namely, when one has a
thingpackage sayand mistakenly tries to define a
thingtask at the root of the build:Without this PR's changes, one gets an error looking like
With this PR, one gets something like
With this PR's changes, the error points at an error in the user code (user's
build.mill) rather than in Mill generated sources. This helps make sense of the error, but is also important in IDEs, where we get an error diagnostic at the right location.About changes in the wrapping, this basically adds one line per subfolder reference, at the beginning of
abstract class package_, like(edited for clarity)
This basically makes the user task try to redefine an existing method, rather than Mill's generated code doing it.