Skip to content

Relax pyparsing requirement. - #812

Merged
decalage2 merged 1 commit into
decalage2:masterfrom
vertexproject:feat_pyparsing
Apr 25, 2024
Merged

decalage2 merged 1 commit into
decalage2:masterfrom
vertexproject:feat_pyparsing

Conversation

@vEpiphyte

Copy link
Copy Markdown
Contributor

All oletools unit tests pass with pyparsing 3.0.9 installed.
This makes it easier to use oletools as a library.

@decalage2
decalage2 self-requested a review April 23, 2023 15:18
@decalage2 decalage2 self-assigned this Apr 23, 2023
@decalage2

Copy link
Copy Markdown
Owner

If I remember well, the requirement to keep pyparsing 2.x is due to ViperMonkey, which does not work with pyparsing 3 (and requires oletools).
But if you only use oletools without ViperMonkey indeed it may work.

@vEpiphyte

Copy link
Copy Markdown
Contributor Author

I see that specific constraint for ViperMonkey here https://github.com/decalage2/ViperMonkey/blob/master/requirements.txt#L6

The vipermonkey tests don't currently run python 3 so I haven't explored if any tests fail on pyparsing 3.x yet.

@CRogos

CRogos commented Mar 7, 2024 •

Copy link
Copy Markdown

We are also getting version conflicts in odoo. We need a version that supports pyparsing>3
Couldn't we restrict ViperMonkey to oletools<=60.1?

OCA/social#1316

@CRogos

CRogos commented Mar 18, 2024

Copy link
Copy Markdown

I've added a PR decalage2/ViperMonkey#125 to ViperMonkey. @decalage2 I think this project should move on, if it is working with newer pyparsing versions.

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit by the same issue on Odoo.sh

@gbtechnology

Copy link
Copy Markdown

@vEpiphyte
@decalage2
this has been opened over 1 year ago. Is there something blocking this merge?

@vEpiphyte

Copy link
Copy Markdown
Contributor Author

@gbtechnology I am not a maintainer on this project. I cannot merge it.

@decalage2
decalage2 merged commit 78b2d45 into decalage2:master Apr 25, 2024
@vEpiphyte
vEpiphyte deleted the feat_pyparsing branch April 26, 2024 00:35
@CRogos

CRogos commented Apr 29, 2024

Copy link
Copy Markdown

@decalage2 will you also release a new version so this change gets available via pip?

@johnlandonwood

Copy link
Copy Markdown

@decalage2 will you also release a new version so this change gets available via pip?

Seconding this, would be a huge help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants