Repository navigation
feat: enable uds cli next mode - #1463
Conversation
Greptile SummaryThe PR enables Next mode while retaining legacy non-bundle commands and updates Zarf argument forwarding and feature resolution. It also broadens unit-test coverage and repairs the preparation task dependency.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported dangling Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Default[default task] --> Test[test task]
Test --> Preparation[test:preparation]
Preparation --> Unit[unit]
Preparation --> Architecture[architecture]
Reviews (2): Last reviewed commit: "fix: command propogation with zarf" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR enables the βNextβ mode in uds by wiring the entrypoint to the new CLI root command when the NextMode feature flag is enabled, and broadens the unit test task to run across all Go packages.
Changes:
- Enable
mode.Nextincmd/uds/main.goby constructing the Next CLI root command withiostreams. - Update the unit test task to run
go testacrosscmd,internal, andpkgpackage trees. - Update
cmd/uds/main_test.goto assertrun()succeeds whenNextMode=trueis provided via--features.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tasks/tests.yaml | Expands unit test scope and removes the legacy:unit task alias. |
| cmd/uds/main.go | Enables Next-mode CLI root command creation and execution. |
| cmd/uds/main_test.go | Updates tests to validate Next-mode execution succeeds. |
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10081b92d6
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@greptileai review |
|
@codex review |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58e0725d0b
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
π‘ Codex Review
Lines 201 to 202 in c67071b
When Next mode is invoked through the shorthand tested here, for example CLI_FEATURES=NextMode=true,values=false uds tools z version, this branch recognizes z and injects the Zarf feature flag, but NewZarfCommand declares only Use: "zarf" and no Aliases. Cobra therefore rejects z as an unknown command before the wrapper runs, so the newly added alias path and its test of Resolve do not correspond to an executable CLI path; either register z on the nested command or stop treating it as supported.
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
Enables UDS CLI Next mode. Also enables the unit tests.
Related Issue
Relates to CLI-263
Type of change
Checklist before merging