Skip to content

chore(ci): add check to verify vendored dependencies - #1551

Merged
jasonwashburn merged 4 commits into
mainfrom
chore/ci-add-vendor-check
Sep 14, 2026
Merged

jasonwashburn merged 4 commits into
mainfrom
chore/ci-add-vendor-check

Conversation

@jasonwashburn

@jasonwashburn jasonwashburn commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds check to CI to verify that ./vendor directory is up to date, matches the expected output of go mod vendor and contains no unintended or undesired changes. If there are modifications present after running go mod vendor, the job fails.

Evidence of expected failing behavior in 60aefad when adding an additional file, and modifying one of the vendored dependencies.
Action: https://github.com/defenseunicorns/uds-cli/actions/runs/34612830133/job/103307325591
image

Related Issue

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@jasonwashburn jasonwashburn self-assigned this Sep 11, 2026
@jasonwashburn
jasonwashburn force-pushed the chore/ci-add-vendor-check branch from 5af1f07 to 60aefad Compare September 11, 2026 14:53
@jasonwashburn
jasonwashburn marked this pull request as ready for review September 11, 2026 16:02
@jasonwashburn
jasonwashburn requested a review from a team as a code owner September 11, 2026 16:02
Copilot AI lite review requested due to automatic review settings September 11, 2026 16:02
@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new CI check consistently detects stale committed vendored dependencies.

Summary

  • Runs go mod vendor after existing lint checks.
  • Reports detected vendor changes with remediation instructions.
  • Correctly scopes status detection to the repository’s single tracked vendor directory.

Reviews (1) Β· Last reviewed commit: "Revert "chore: validate that check fails..."

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Approval recommended

No unresolved issues were identified.

Pull request overview

Adds a CI check to verify that the committed vendor/ directory matches go mod vendor.

Changes:

  • Runs go mod vendor in the lint workflow.
  • Fails if generated vendor changes are detected.
File summaries
File Description
.github/workflows/test.yaml Adds vendored dependency consistency validation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

πŸ’‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jasonwashburn
jasonwashburn merged commit 37bdfa2 into main Sep 14, 2026
24 checks passed
@jasonwashburn
jasonwashburn deleted the chore/ci-add-vendor-check branch September 14, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants