Skip to content

fix: require --architecture to be non-empty - #1552

Merged
bradclawsie merged 2 commits into
mainfrom
cli-316
Sep 11, 2026
Merged

bradclawsie merged 2 commits into
mainfrom
cli-316

Conversation

@bradclawsie

Copy link
Copy Markdown
Contributor

Description

--architecture previously allowed a vacuous setting. It seemed sensible to assume that this parameter should actually be set, or the flag omitted. This change requires a non-vacuous paramater if the flag is present.
...

Related Issue

Fixes CLI-316

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@bradclawsie
bradclawsie marked this pull request as ready for review September 11, 2026 15:47
@bradclawsie
bradclawsie requested a review from a team as a code owner September 11, 2026 15:47
@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; both command paths reject explicitly empty architecture values before command execution.

Summary

  • Adds validation before normal command setup and execution.
  • Preserves existing behavior when the flag is omitted or has a value.
  • Adds regression coverage for both command implementations.

Reviews (1) Β· Last reviewed commit: "fix: require --architecture to be non-em..."

@bradclawsie

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-09-11T15:57:45.021588Z 7da657f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7da657fbb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/legacy/cli/root.go Resolved

@chance-coleman chance-coleman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’ͺ🏼

@bradclawsie
bradclawsie merged commit 4609795 into main Sep 11, 2026
24 checks passed
@bradclawsie
bradclawsie deleted the cli-316 branch September 11, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants