Repository navigation
chore(deps)!: update zarf to v0.87.0 - #1585
Conversation
| datasource | package | from | to | | --------------- | ------------------------------ | ------- | ------- | | docker | ghcr.io/zarf-dev/packages/init | v0.86.0 | v0.87.0 | | go | github.com/zarf-dev/zarf | v0.86.0 | v0.87.0 | | github-releases | zarf-dev/zarf | v0.86.0 | v0.87.0 | | github-tags | zarf-dev/zarf | v0.86.0 | v0.87.0 |
|
Zarf breaking changes for 0.87 and additional changes to make tests, CI happy Some changes here are applied to Legacy. Until we retire it and remove it, I feel we should make changes there if they are real correctness issues. Don't be too put off by the lines changed, most of this is in vendoring and |
|
Still working on reviewing but so far I see that we will need to create 2 follow on tickets, one for being version neutral with the zarf schema as this PR converts to v1alpha which isn't an immediate issue, and moving from defenseunicorns/oci to the zarf one |
I had made a ticket for this myself this morning: https://linear.app/defense-unicorns/issue/CLI-356/replace-defenseunicornspkg-with-zarf-local-copy Not knowing when this would happen. I asked Brandt this morning if the |
chance-coleman
left a comment
There was a problem hiding this comment.
A few questions, two may be blocking
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
@greptileai review |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17fcf5acd3
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
@greptileai review |
|
@codex review |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e4ac85be9
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with π. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@greptileai review |
There was a problem hiding this comment.
Comments to provide context for reviewers; read them in the file diff view.
Note that the breaking changes in this PR will require nudging the generated release notes; for reference: https://github.com/googleapis/release-please#how-can-i-fix-release-notes (thanks @slaskawi !)
slaskawi
left a comment
There was a problem hiding this comment.
Added a few comments but I'm generally good with the direction
β¦CI layers" This reverts commit 6cbfe01.
This PR contains the following updates:
v0.86.0βv0.87.0v0.86.0βv0.87.00.86.0β0.87.0v0.86.0βv0.87.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
zarf-dev/zarf (github.com/zarf-dev/zarf)
v0.87.0β BREAKING CHANGES
Features
Bug Fixes
Refactoring
Configuration
π Schedule: (in timezone America/New_York)
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.
BEGIN_COMMIT_OVERRIDE
chore(deps)!: update zarf to v0.87.0 (#1585)
BREAKING CHANGE: Zarf v0.87 breaking changes. See: https://github.com/zarf-dev/zarf/releases/tag/v0.87.0 (#1585) (ee139b9)
END_COMMIT_OVERRIDE