Skip to content

feat: skip architecture check - #1615

Merged
eoghanriley merged 29 commits into
mainfrom
eoghanriley/cli-381
Oct 20, 2026
Merged

eoghanriley merged 29 commits into
mainfrom
eoghanriley/cli-381

Conversation

@eoghanriley

@eoghanriley eoghanriley commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR exposes the new zarf --skip-architecture-check flag to both legacy and next cli. This can be used either by adding the --skip-architecture-check flag to deploy commands or putting it in the bundle config.

Related Issue

Fixes CLI-381

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

renovate Bot and others added 4 commits October 16, 2026 03:51
| datasource      | package                        | from    | to      |
| --------------- | ------------------------------ | ------- | ------- |
| docker          | ghcr.io/zarf-dev/packages/init | v0.87.0 | v0.88.0 |
| go              | github.com/zarf-dev/zarf       | v0.87.0 | v0.88.0 |
| github-releases | zarf-dev/zarf                  | v0.87.0 | v0.88.0 |
| github-tags     | zarf-dev/zarf                  | v0.87.0 | v0.88.0 |
@eoghanriley
eoghanriley changed the base branch from main to renovate/zarf October 16, 2026 21:33
@eoghanriley
eoghanriley added this pull request to stack #1616 October 16, 2026 21:33
@eoghanriley
eoghanriley marked this pull request as ready for review October 19, 2026 18:18
@eoghanriley
eoghanriley requested a review from a team as a code owner October 19, 2026 18:18
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects bundle deployment behavior in both CLI paths.

Regenerate the embedded migration documentation before merging so its checks pass.

Findings

  1. P1Β Migration documentation checks fail β–Ά

Summary

Adds --skip-architecture-check and matching configuration settings to legacy and Next deployment commands.

  • CLI Next deploys can pass an architecture override to Zarf.
  • Legacy deploys can skip the bundle architecture check.

Reviews (2) Β· Last reviewed commit: "chore: add zarfs not for prod warning to..." Β· Reviewed by Greptile

Comment thread pkg/bundle/deploy.go Resolved
Comment thread pkg/legacy/bundle/remote.go Resolved

@joelmccoy joelmccoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for consideration

Comment thread docs/getting-started/quickstart.mdx Resolved
Comment thread docs/reference/next/config-uds-hcl.mdx Resolved
Comment thread internal/cli/bundle/deploy.go Resolved
Comment thread internal/cli/bundle/deploy_runner.go Resolved
Comment thread internal/cli/bundle/deploy_runner.go Resolved
Comment thread pkg/legacy/bundle/remote.go Resolved
joelmccoy
joelmccoy previously approved these changes Oct 19, 2026
slaskawi
slaskawi previously approved these changes Oct 20, 2026
Base automatically changed from renovate/zarf to main October 20, 2026 18:31
# Conflicts:
#	internal/zarf/deploy.go
#	pkg/legacy/bundle/deploy.go
@eoghanriley
eoghanriley dismissed stale reviews from slaskawi and joelmccoy via f82c4d2 October 20, 2026 18:39
@eoghanriley
eoghanriley merged commit 53483c0 into main Oct 20, 2026
104 of 125 checks passed
@eoghanriley
eoghanriley deleted the eoghanriley/cli-381 branch October 20, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants