Skip to content

feat!: support Zarf beta schemas in both CLI modes - #1621

Merged
joelmccoy merged 6 commits into
mainfrom
sebastianlaskawiec/cli-363
Nov 2, 2026
Merged

joelmccoy merged 6 commits into
mainfrom
sebastianlaskawiec/cli-363

Conversation

@slaskawi

@slaskawi slaskawi commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Use Zarf's shared model and parser in Legacy and Next. Preserve package schemas and Next public APIs.

Related Issue

CLI-363

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Commit override

BEGIN_COMMIT_OVERRIDE
feat!: support Zarf beta schemas in both CLI modes

BREAKING CHANGE: Legacy Go integrations must use Zarf's api.Package and api.Component types for package readers and fetchers. CLI commands and Next public APIs remain compatible.

Zarf package migration guide: https://docs.zarf.dev/best-practices/v1alpha1-to-v1beta1/
END_COMMIT_OVERRIDE

Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
@slaskawi
slaskawi requested a balanced review from Copilot October 29, 2026 06:38

Copy link
Copy Markdown
Contributor Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
πŸ“ Code Review βœ… Completed 2026-10-29T06:42:02.819352Z 7d9f569 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with πŸ‘€ while any review is running, comments if it has suggestions, and reacts with πŸ‘ once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. πŸ‘

Reviewed commit: 7d9f569708

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@slaskawi

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes reviewed appear safe to merge.

Summary

Legacy now uses Zarf’s shared package model and parser, preserving beta fields during reads, filtering, and deployment. Next keeps its public APIs unchanged.

  • Legacy bundle flows carry alpha and beta package fields through to package operations.
  • Next reads package names from Zarf’s shared definition.
  • A task checklist records the work and remaining steps for CLI-363.

No new actionable issues were found in the changes since the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Alpha or beta package] --> B[Zarf shared parser and model]
  B --> C[Legacy metadata and component filters]
  B --> D[Next package layout]
  C --> E[Zarf deployment]
  D --> E
Loading

Reviews (2) Β· Last reviewed commit: "comments addressed" Β· Reviewed by Greptile

Comment thread pkg/legacy/bundle/inspect.go Resolved
Comment thread pkg/legacy/bundle/schema_test.go Resolved
Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
@slaskawi
slaskawi marked this pull request as ready for review October 30, 2026 06:52
@slaskawi
slaskawi requested a review from a team as a code owner October 30, 2026 06:52
Comment thread tasks/todo.md Resolved
Comment thread docs/reference/schema-validation.mdx Resolved
Comment thread tests/library/schema_test.go Resolved

@joelmccoy joelmccoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good. Just would like to see @eoghanriley 's comments addressed. They are similar things I noticed and commented on as well.

…i-363

Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
@slaskawi

slaskawi commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @joelmccoy and @eoghanriley !

All the comments addressed and the test suite has been slightly adjusted to the Pyramid Shape (following the ADR 27)

@joelmccoy
joelmccoy merged commit 74b2549 into main Nov 2, 2026
53 of 54 checks passed
@joelmccoy
joelmccoy deleted the sebastianlaskawiec/cli-363 branch November 2, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants