Repository navigation
feat!: support Zarf beta schemas in both CLI modes - #1621
Conversation
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. π Reviewed commit: βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with π. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@greptileai review |
[Medium impact] The changes reviewed appear safe to merge. SummaryLegacy now uses Zarfβs shared package model and parser, preserving beta fields during reads, filtering, and deployment. Next keeps its public APIs unchanged.
No new actionable issues were found in the changes since the previous review. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Alpha or beta package] --> B[Zarf shared parser and model]
B --> C[Legacy metadata and component filters]
B --> D[Next package layout]
C --> E[Zarf deployment]
D --> E
Reviews (2) Β· Last reviewed commit: "comments addressed" Β· Reviewed by Greptile |
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
joelmccoy
left a comment
There was a problem hiding this comment.
Mostly looking good. Just would like to see @eoghanriley 's comments addressed. They are similar things I noticed and commented on as well.
β¦i-363 Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
|
Thanks for the review @joelmccoy and @eoghanriley ! All the comments addressed and the test suite has been slightly adjusted to the Pyramid Shape (following the ADR 27) |
Description
Use Zarf's shared model and parser in Legacy and Next. Preserve package schemas and Next public APIs.
Related Issue
CLI-363
Type of change
Checklist before merging
Commit override