Repository navigation
fix: testsuite fixed for the release - #1629
Conversation
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
There was a problem hiding this comment.
π’ Approval recommended
No active review issues were identified for the Zarf v0.89 compatibility and schema-specific SBOM preservation updates.
No open issues π
What changed in this PR
Restores compatibility with Zarf v0.89 following the dependency update associated with release #1622, preserving schema-specific SBOM files during Legacy bundle creation and updating test fixtures.
Changes:
- Preserve archived SBOMs for v1alpha1 packages and individual SBOM resources for newer schemas.
- Update Legacy test fixtures to use Zarfβs current image archive types and init-package constant.
- Adjust beta-schema output expectations across library, CLI, and Legacy end-to-end tests.
| File | Description |
|---|---|
tests/βlibrary/βschema_test.go |
Update beta output expectation to omit the trailing newline. |
tests/βlegacy/βe2e/βbundle_test.go |
Align beta deployment output assertions with Zarf v0.89. |
tests/βcli/βcmd/βbundle/βcreate_integration_test.go |
Update the beta deployment output expectation. |
pkg/βlegacy/βutils/βboci/βoci_test.go |
Use api.ArchiveImage in image-filtering fixtures. |
pkg/βlegacy/βbundler/βfetcher/βcommon.go |
Preserve SBOM files according to the package schema. |
pkg/βlegacy/βbundle/βinspect_test.go |
Use api.ArchiveImage in bundle inspection fixtures. |
pkg/βlegacy/βbundle/βdeploy_test.go |
Use api.ZarfInitConfig in deployment option assertions. |
Review effort: Balanced
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryPreserves schema-specific SBOM files when creating legacy bundles and updates tests for the current Zarf types and template output.
Reviews (2) Β· Last reviewed commit: "test: cover schema-specific SBOM filteri..." Β· Reviewed by Greptile |
Signed-off-by: Sebastian Εaskawiec <sebastian.laskawiec@defenseunicorns.com>
|
Added focused file-list coverage for alpha and beta packages with and without SBOMs, including optional-component filtering. |
Description
Update test fixtures and preserve schema-specific SBOM files when creating bundles.
Related Issue
Relates to #1622
Type of change
Checklist before merging