Skip to content

Avoid copying transitive task dependencies - #12470

Merged
simonrozsival merged 1 commit into
mainfrom
jonathanpeppers-fix-build-tasks-shared-output
Aug 21, 2026
Merged

simonrozsival merged 1 commit into
mainfrom
jonathanpeppers-fix-build-tasks-shared-output

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Description

Port the shared-output fix from #12468 to main by disabling CopyLocalLockFileAssemblies for Microsoft.Android.Build.Tasks.

The project shares the SDK pack tools output with Xamarin.Android.Build.Tasks; preventing transitive runtime asset copies avoids replacing compatible shared assemblies with framework-specific implementations.

Validation

Built Microsoft.Android.Build.Tasks.csproj into an isolated shared SDK tools output and confirmed:

  • System.IO.Hashing.dll is not copied
  • Microsoft.Android.Build.BaseTasks.dll remains copied
  • Microsoft.Android.Build.Tasks.dll is produced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5798fe53-b8b3-44e5-b67a-3fc057067981
Copilot AI lite review requested due to automatic review settings August 20, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports the β€œshared output” fix to main by preventing NuGet from copying transitive runtime assets into the shared SDK pack tools output used by both Microsoft.Android.Build.Tasks and Xamarin.Android.Build.Tasks, avoiding accidental overwrites of compatible assemblies.

Changes:

  • Disable CopyLocalLockFileAssemblies for Microsoft.Android.Build.Tasks to stop transitive runtime asset copying into the shared tools folder.
  • Add an explanatory comment documenting why the copy behavior must be disabled when sharing $(OutputPath).

@simonrozsival
simonrozsival merged commit af7c858 into main Aug 21, 2026
45 checks passed
@simonrozsival
simonrozsival deleted the jonathanpeppers-fix-build-tasks-shared-output branch August 21, 2026 09:06
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants