Repository navigation
[release/10.0] Fix installer background for bundles - #68932
Merged
Merged
Conversation
wtgodbe
changed the title
wtgodbe
added
the
tell-mode
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Backports #68930 to the release/10.0 branch to fix the header/banner background rendering in the Windows bundle installers by aligning the theme behavior with dotnet/sdk.
Changes:
- Update the banner font to use white foreground and corrected brand background color.
- Replace the title/subtitle
<Text>elements with layered<Label>elements to produce an opaque banner background and centered title text.
File summaries
| File | Description |
|---|---|
| src/Installers/Windows/WindowsHostingBundle/bundle.thm | Adjusts banner font colors and reworks title/subtitle rendering using layered labels for correct background. |
| src/Framework/App.Runtime/bundle/bundle.thm | Applies the same banner font update and label layering for the runtime bundle title header background. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
joeloff
approved these changes
Aug 31, 2026
leveyp94-hash
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #68930
Mimic what dotnet/sdk does for installer backgrounds