Skip to content

[dotnet/msbuild] Don't bundle *.xml files that match any assemblies. Fixes #14939 and fixes #15897. - #17908

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:xml-publishfoldertype
Mar 30, 2023
Merged

rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:xml-publishfoldertype

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

This fixes a warning when documentation is enabled for a project:

The file '~/.nuget/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle.

This doesn't change any behavior (as the warning says, the file wasn't copied
to the app bundle before either), but it makes the behavior explicitly
documented and silences the warning.

Fixes #14939.
Fixes #15897.

…Fixes dotnet#14939 and fixes dotnet#15897.

This fixes a warning when documentation is enabled for a project:

> The file '~/.nuget/packages/fsharp.core/6.0.0/contentFiles/any/netstandard2.1/FSharp.Core.xml' does not specify a 'PublishFolderType' metadata, and a default value could not be calculated. The file will not be copied to the app bundle.

This doesn't change any behavior (as the warning says, the file wasn't copied
to the app bundle before either), but it makes the behavior explicitly
documented and silences the warning.

Fixes dotnet#14939.
Fixes dotnet#15897.
@rolfbjarne
rolfbjarne requested review from emaf and mauroa as code owners March 27, 2023 20:11
@rolfbjarne rolfbjarne changed the title [dotnet/msbuild] Don't bundle *.xml files that matches any assemblies. Fixes #14939 and fixes #15897. [dotnet/msbuild] Don't bundle *.xml files that match any assemblies. Fixes #14939 and fixes #15897. Mar 27, 2023
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

βœ… API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

βœ… Generator diff

Generator diff is empty

Pipeline on Agent
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build] Windows Integration Tests passed πŸ’»

βœ… All Windows Integration Tests passed.

Pipeline on Agent
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed πŸ’»

βœ… All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ“š [PR Build] Artifacts πŸ“š

Packages generated

View packages

Pipeline on Agent XAMBOT-1035.Ventura
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ”₯ [CI Build] Test results πŸ”₯

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 223 tests passed.

Failures

❌ dotnettests tests

1 tests failed, 0 tests passed.
Details
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ monotouch tests

1 tests failed, 24 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): TimedOut

Html Report (VSDrops) Download

Successes

βœ… bcl: All 69 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 7 tests passed. Html Report (VSDrops) Download
βœ… framework: All 8 tests passed. Html Report (VSDrops) Download
βœ… generator: All 2 tests passed. Html Report (VSDrops) Download
βœ… interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
βœ… install_source: All 1 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 8 tests passed. Html Report (VSDrops) Download
βœ… linker: All 65 tests passed. Html Report (VSDrops) Download
βœ… mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
βœ… mmp: All 2 tests passed. Html Report (VSDrops) Download
βœ… mononative: All 12 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… mtouch: All 1 tests passed. Html Report (VSDrops) Download
βœ… xammac: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 8 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a86f1d562418d739ad19f815fe77a140ef6c3bed [PR build]

@rolfbjarne
rolfbjarne merged commit 335f8c9 into dotnet:main Mar 30, 2023
@rolfbjarne
rolfbjarne deleted the xml-publishfoldertype branch March 30, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants