Skip to content

[msbuild] Merge the GetMlaunchArguments and GetMlaunchArgumentsTaskBase classes. - #18071

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:merge-getmlauncharguments
Apr 18, 2023
Merged

rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:merge-getmlauncharguments

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

We no longer need two have overridable logic for remote builds, so the
non-abstract task class and the abstract base class can be merged.

Also enable nullability and fix any issues.

…se classes.

We no longer need two have overridable logic for remote builds, so the
non-abstract task class and the abstract base class can be merged.

Also enable nullability and fix any issues.
@rolfbjarne
rolfbjarne requested review from emaf and mauroa as code owners April 14, 2023 09:12
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

βœ… API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

βœ… Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build] Windows Integration Tests passed πŸ’»

βœ… All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ“š [PR Build] Artifacts πŸ“š

Packages generated

View packages

Pipeline on Agent XAMBOT-1035.Ventura
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed πŸ’»

βœ… All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build] Test results πŸš€

Test results

βœ… All tests passed on VSTS: simulator tests.

πŸŽ‰ All 225 tests passed πŸŽ‰

Tests counts

βœ… bcl: All 69 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests: All 1 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 7 tests passed. Html Report (VSDrops) Download
βœ… framework: All 8 tests passed. Html Report (VSDrops) Download
βœ… generator: All 2 tests passed. Html Report (VSDrops) Download
βœ… interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
βœ… install_source: All 1 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 8 tests passed. Html Report (VSDrops) Download
βœ… linker: All 65 tests passed. Html Report (VSDrops) Download
βœ… mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
βœ… mmp: All 2 tests passed. Html Report (VSDrops) Download
βœ… mononative: All 12 tests passed. Html Report (VSDrops) Download
βœ… monotouch: All 25 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… mtouch: All 1 tests passed. Html Report (VSDrops) Download
βœ… xammac: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 8 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5a8cacdf139b66770e22931f81b8dcdd7a2b70a5 [PR build]

@rolfbjarne
rolfbjarne merged commit 0f648fb into dotnet:main Apr 18, 2023
@rolfbjarne
rolfbjarne deleted the merge-getmlauncharguments branch April 18, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants