Skip to content

[dotnet] Use the type_map_path arg - #18175

Merged
stephen-hawley merged 1 commit into
dotnet:mainfrom
stephen-hawley:generate-output
May 1, 2023
Merged

stephen-hawley merged 1 commit into
dotnet:mainfrom
stephen-hawley:generate-output

Conversation

@stephen-hawley

Copy link
Copy Markdown
Contributor

Removed the default argument value
Added Application.ClassMapPath
Added options and setter for ClassMapPath
Integrated usage.

Note that the test for whether or not to write the file is based on whether the path passed in is null or empty, so this should cause no immediate problems.

@stephen-hawley stephen-hawley added not-notes-worthy Ignore for release notes dotnet An issue or pull request related to .NET labels Apr 27, 2023
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 9c00d375be34f6e89cac27f7b9e507e789966331 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ“š [PR Build] Artifacts πŸ“š

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

βœ… API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

βœ… Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 9c00d375be34f6e89cac27f7b9e507e789966331 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build] Test results πŸš€

Test results

βœ… All tests passed on VSTS: simulator tests.

πŸŽ‰ All 225 tests passed πŸŽ‰

Tests counts

βœ… bcl: All 69 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests: All 1 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 7 tests passed. Html Report (VSDrops) Download
βœ… framework: All 8 tests passed. Html Report (VSDrops) Download
βœ… generator: All 2 tests passed. Html Report (VSDrops) Download
βœ… interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
βœ… install_source: All 1 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 8 tests passed. Html Report (VSDrops) Download
βœ… linker: All 65 tests passed. Html Report (VSDrops) Download
βœ… mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
βœ… mmp: All 2 tests passed. Html Report (VSDrops) Download
βœ… mononative: All 12 tests passed. Html Report (VSDrops) Download
βœ… monotouch: All 25 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… mtouch: All 1 tests passed. Html Report (VSDrops) Download
βœ… xammac: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 8 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9c00d375be34f6e89cac27f7b9e507e789966331 [PR build]

@stephen-hawley
stephen-hawley merged commit 2ec000d into dotnet:main May 1, 2023
@stephen-hawley
stephen-hawley deleted the generate-output branch May 1, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet An issue or pull request related to .NET not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants