Skip to content

[NativeAOT] Add support for conditional [Preserve] attributes - #18803

Merged
rolfbjarne merged 4 commits into
dotnet:net8.0from
simonrozsival:transform-preserve-conditional-into-dynamic-dependency-attribute
Aug 25, 2023
Merged

rolfbjarne merged 4 commits into
dotnet:net8.0from
simonrozsival:transform-preserve-conditional-into-dynamic-dependency-attribute

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

This is a follow-up to #18666

The idea is to transform [Preserve(Conditional = true)] into [DynamicDependency(signature, type)] on the static constructor of the given type:

class MyClass {
    [Preserve (Conditional = true)]
    public void MyMethod () { }

    // transformed into ...

    [DynamicDependency ("MyMethod", typeof (MyClass))]
    static MyClass() { /* either the existing cctor or a new empty cctor */ }

    public void MyMethod () { }
}

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

…to transform-preserve-conditional-into-dynamic-dependency-attribute
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure in the windows tests should go away if you merge the net8.0 branch into this branch.

return;

// I haven't found a way to express a conditional Preserve attribute using DynamicDependencyAttribute :/
ErrorHelper.Warning (2112, Errors.MX2112 /* Unable to apply the conditional [Preserve] attribute on the member {0} */, forMethod.FullName);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the error message from the resx file.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [CI Build] Windows Integration Tests passed πŸ’»

βœ… All Windows Integration Tests passed.

Pipeline on Agent
Hash: 14f083407fe4151c839f8606d469730dea5465fb [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ“š [PR Build] Artifacts πŸ“š

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed πŸ’»

βœ… All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸ’» [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed πŸ’»

βœ… All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

βœ… API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 14f083407fe4151c839f8606d469730dea5465fb [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build] Test results πŸš€

Test results

βœ… All tests passed on VSTS: simulator tests.

πŸŽ‰ All 232 tests passed πŸŽ‰

Tests counts

βœ… bcl: All 69 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests: All 1 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 7 tests passed. Html Report (VSDrops) Download
βœ… framework: All 8 tests passed. Html Report (VSDrops) Download
βœ… generator: All 2 tests passed. Html Report (VSDrops) Download
βœ… interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
βœ… install_source: All 1 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 8 tests passed. Html Report (VSDrops) Download
βœ… linker: All 65 tests passed. Html Report (VSDrops) Download
βœ… mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
βœ… mmp: All 2 tests passed. Html Report (VSDrops) Download
βœ… mononative: All 6 tests passed. Html Report (VSDrops) Download
βœ… monotouch: All 38 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… mtouch: All 1 tests passed. Html Report (VSDrops) Download
βœ… xammac: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 8 tests passed. Html Report (VSDrops) Download
βœ… xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 14f083407fe4151c839f8606d469730dea5465fb [PR build]

@rolfbjarne
rolfbjarne merged commit 4ddee61 into dotnet:net8.0 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants