Repository navigation
[NativeAOT] Add support for conditional [Preserve] attributes - #18803
Conversation
|
β¦to transform-preserve-conditional-into-dynamic-dependency-attribute
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rolfbjarne
left a comment
There was a problem hiding this comment.
The failure in the windows tests should go away if you merge the net8.0 branch into this branch.
| return; | ||
|
|
||
| // I haven't found a way to express a conditional Preserve attribute using DynamicDependencyAttribute :/ | ||
| ErrorHelper.Warning (2112, Errors.MX2112 /* Unable to apply the conditional [Preserve] attribute on the member {0} */, forMethod.FullName); |
There was a problem hiding this comment.
You can also remove the error message from the resx file.
π» [CI Build] Windows Integration Tests passed π»β All Windows Integration Tests passed. Pipeline on Agent |
π [PR Build] Artifacts πPackages generatedView packagesPipeline on Agent |
π» [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed π»β All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
π» [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed π»β All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
β API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
β API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)βΉοΈ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
π [CI Build] Test results πTest resultsβ All tests passed on VSTS: simulator tests. π All 232 tests passed π Tests countsβ
bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is a follow-up to #18666
The idea is to transform
[Preserve(Conditional = true)]into[DynamicDependency(signature, type)]on the static constructor of the given type: