Skip to content

[MediaAccessibility] Add xcode 15 beta 7 support. - #19016

Merged
dalexsoto merged 3 commits into
dotnet:net8.0-xcode15from
mandel-macaque:net8.0-xcode15-mediaaccessibility
Sep 18, 2023
Merged

[MediaAccessibility] Add xcode 15 beta 7 support.#19016
dalexsoto merged 3 commits into
dotnet:net8.0-xcode15from
mandel-macaque:net8.0-xcode15-mediaaccessibility

Conversation

@mandel-macaque

@mandel-macaque mandel-macaque commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

rolfbjarne
rolfbjarne requested changes Sep 13, 2023
View reviewed changes
Comment thread src/mediaaccessibility.cs Outdated
bool CanProcess (Surface surface);

[Export ("processSurface:outSurface:timestamp:options:")]
MAFlashingLightsProcessorResult Process (Surface inSurface, Surface outSurface, double timestamp, [NullAllowed] NSDictionary<NSString, NSObject> options);

@rolfbjarne rolfbjarne Sep 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the options be a strong dictionary?

@mandel-macaque mandel-macaque Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find any documentation about the keys or values. https://developer.apple.com/documentation/mediaaccessibility/maflashinglightsprocessoroptionkey?language=objc

Or in the header: https://github.com/xamarin/xamarin-macios/wiki/MediaAccessibility-iOS-xcode15.0-b1

@stephen-hawley stephen-hawley Sep 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I also looked at the Swift doc'n and the key, oddly enough, is not an NSString, which is an inner struct called MAFlashingLightsProcessor.OptionKey which has initializers from String - it feels like they're keeping their options open for the future, but the values of the options are also untyped there and undocumented.

@mandel-macaque mandel-macaque Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice the same, we should leave it as open as possible.

@github-actions

github-actions Bot commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto approved these changes Sep 14, 2023
View reviewed changes
Comment thread src/mediaaccessibility.cs Resolved
@mandel-macaque @dalexsoto
Update src/mediaaccessibility.cs
a8d2f44 
Co-authored-by: Alex Soto <alex@alexsoto.me>
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: a8d2f44e6ef31659ce7fd9c1d2d20749d8363ab1 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: a8d2f44e6ef31659ce7fd9c1d2d20749d8363ab1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 238 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: a8d2f44e6ef31659ce7fd9c1d2d20749d8363ab1 [PR build]

@dalexsoto
dalexsoto merged commit 72ee9e9 into dotnet:net8.0-xcode15 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@rolfbjarne rolfbjarne rolfbjarne approved these changes
+2 more reviewers
@stephen-hawley stephen-hawley stephen-hawley left review comments
@haritha-mohan haritha-mohan haritha-mohan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @stephen-hawley @haritha-mohan