Skip to content

[SensitiveContentAnalysis] Add support for Xcode 15 - #19020

Merged
haritha-mohan merged 4 commits into
dotnet:net8.0-xcode15from
haritha-mohan:net8.0-xcode15-screencontentanalysis
Sep 15, 2023
Merged

[SensitiveContentAnalysis] Add support for Xcode 15#19020
haritha-mohan merged 4 commits into
dotnet:net8.0-xcode15from
haritha-mohan:net8.0-xcode15-screencontentanalysis

Conversation

@haritha-mohan

@haritha-mohan haritha-mohan commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@haritha-mohan haritha-mohan changed the title [ScreenContentAnalysis] Add support for Xcode 15 [SensitiveContentAnalysis] Add support for Xcode 15 Sep 14, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto requested changes Sep 14, 2023
View reviewed changes
Comment thread src/sensitivecontentanalysis.cs Resolved
Comment thread src/sensitivecontentanalysis.cs Resolved
@haritha-mohan @dalexsoto
Apply suggestions from code review
4d0ac18 
Co-authored-by: Alex Soto <alex@soto.dev>
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
mandel-macaque
mandel-macaque approved these changes Sep 14, 2023
View reviewed changes

@mandel-macaque mandel-macaque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haritha-mohan lets fix the copyright, or not even add it :)

Comment thread src/sensitivecontentanalysis.cs Outdated
@@ -0,0 +1,47 @@
// Copyright 2016 Xamarin Inc. All rights reserved.

@mandel-macaque mandel-macaque Sep 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haritha-mohan is back to the future ;)

@haritha-mohan haritha-mohan Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol fixed

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 143c8858ed56278b75c3f6fe2d70d452465c31e4 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: 143c8858ed56278b75c3f6fe2d70d452465c31e4 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 238 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 143c8858ed56278b75c3f6fe2d70d452465c31e4 [PR build]

@haritha-mohan
haritha-mohan merged commit 4f1cbbc into dotnet:net8.0-xcode15 Sep 15, 2023
@haritha-mohan
haritha-mohan deleted the net8.0-xcode15-screencontentanalysis branch September 15, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@rolfbjarne rolfbjarne rolfbjarne approved these changes
+2 more reviewers
@mandel-macaque mandel-macaque mandel-macaque approved these changes
@stephen-hawley stephen-hawley stephen-hawley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haritha-mohan @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mandel-macaque @stephen-hawley