Skip to content

[release/8.0.1xx] [msbuild] Look for and copy binding resource packages to the remote Mac in the ResolveNativeReferences task. Fixes #19229. - #19334

Merged
dalexsoto merged 1 commit into
dotnet:release/8.0.1xxfrom
vs-mobiletools-engineering-service2:backport-pr-19325-to-release/8.0.1xx
Oct 25, 2023
Merged

[release/8.0.1xx] [msbuild] Look for and copy binding resource packages to the remote Mac in the ResolveNativeReferences task. Fixes #19229.#19334
dalexsoto merged 1 commit into
dotnet:release/8.0.1xxfrom
vs-mobiletools-engineering-service2:backport-pr-19325-to-release/8.0.1xx

Conversation

@vs-mobiletools-engineering-service2

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Fixes #19229.

Backport of #19325

@rolfbjarne vs-mobiletools-engineering-service2
[msbuild] Look for and copy binding resource packages to the remote M…
15da470 
…ac in the ResolveNativeReferences task. Fixes dotnet#19229.

Look for any binding resource packages (a directory named AssemblyName.resources
or a compressed version named AssemblyName.resources.zip) next to any references,
and copy those to the remote Mac when doing remote builds.

Fixes dotnet#19229.
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 added bug If an issue is a bug or a pull request a bug fix backported labels Oct 25, 2023
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 15da4703114e8b6c1e75c2526b3362e1670f9b33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 15da4703114e8b6c1e75c2526b3362e1670f9b33 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator Author

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 15da4703114e8b6c1e75c2526b3362e1670f9b33 [PR build]

@dalexsoto
dalexsoto merged commit b87a808 into dotnet:release/8.0.1xx Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@emaf emaf Awaiting requested review from emaf emaf is a code owner
@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner
@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner
+1 more reviewer
@mandel-macaque mandel-macaque mandel-macaque approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @rolfbjarne