Skip to content

[localization] Include template JSON files in OneLocBuild configuration. Fixes #20717 - #25717

Merged
rolfbjarne merged 3 commits into
mainfrom
dev/rolf/fix-template-loc-config
Jun 22, 2026
Merged

rolfbjarne merged 3 commits into
mainfrom
dev/rolf/fix-template-loc-config

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jun 17, 2026 •

Copy link
Copy Markdown
Member

The templatestrings.en.json files in dotnet/Templates/ were not included in the LocProject.json configuration, which meant OneLocBuild never picked them up for translation.

This PR replaces the static LocProject.json.in template with a generate-loc-project.sh script that dynamically discovers all templatestrings.en.json files and includes them in the generated LocProject.json.

This also fixes a duplicate entry for Microsoft.Macios.Generator/Resources.resx that was in the original .in file.

Hopefully fixes #20717

πŸ€– Pull request created by Copilot

The templatestrings.en.json files in dotnet/Templates were not included in
the LocProject.json configuration, which meant OneLocBuild never translated
them. This caused Polish and Chinese Traditional translations to remain
outdated (still referencing '.NET 6').

Replace the static LocProject.json.in template with a generate-loc-project.sh
script that dynamically discovers all templatestrings.en.json files and
includes them in the generated LocProject.json.

This also fixes a duplicate entry for Microsoft.Macios.Generator/Resources.resx
that was in the original .in file.

Fixes #20717

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
rolfbjarne marked this pull request as ready for review June 18, 2026 16:57
Copilot AI review requested due to automatic review settings June 18, 2026 16:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the localization configuration used by OneLocBuild so that template localization source files (templatestrings.en.json under dotnet/Templates/) are included, fixing missed translations for template strings (issue #20717). It also removes a previously duplicated .resx entry by moving from a static JSON template to a generated file.

Changes:

  • Replace the static LocProject.json.in template with a bash generator that discovers all templatestrings.en.json files under dotnet/Templates/.
  • Update the devops Makefile target to generate Localize/LocProject.json via the new script.
  • Remove the duplicate Microsoft.Macios.Generator/Resources.resx entry by regenerating the list from a single authoritative script.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/devops/Makefile Switches LocProject generation to run the new discovery script.
tools/devops/LocProject.json.in Removes the static template configuration (including a duplicate entry).
tools/devops/generate-loc-project.sh New generator that emits LocProject.json with static .resx items plus discovered template JSON files.

Comment thread tools/devops/Makefile Resolved
Comment thread tools/devops/generate-loc-project.sh Resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rolfbjarne
rolfbjarne enabled auto-merge (squash) June 19, 2026 07:29
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #39bfb36] Build passed (Detect API changes) βœ…

Pipeline on Agent
Hash: 39bfb36dd9c115b3f2e2c34a279352f084bb8e03 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #39bfb36] Build passed (Build packages) βœ…

Pipeline on Agent
Hash: 39bfb36dd9c115b3f2e2c34a279352f084bb8e03 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… API diff for current PR / commit

NET (empty diffs)

βœ… API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 39bfb36dd9c115b3f2e2c34a279352f084bb8e03 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

βœ… [PR Build #39bfb36] Build passed (Build macOS tests) βœ…

Pipeline on Agent
Hash: 39bfb36dd9c115b3f2e2c34a279352f084bb8e03 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

πŸš€ [CI Build #39bfb36] Test results πŸš€

Test results

βœ… All tests passed on VSTS: test results.

πŸŽ‰ All 220 tests passed πŸŽ‰

Tests counts

βœ… assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
βœ… cecil: All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
βœ… dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
βœ… framework: All 2 tests passed. Html Report (VSDrops) Download
βœ… fsharp: All 4 tests passed. Html Report (VSDrops) Download
βœ… generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
βœ… introspection: All 6 tests passed. Html Report (VSDrops) Download
βœ… linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
βœ… linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
βœ… linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
βœ… linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
βœ… monotouch (iOS): All 21 tests passed. Html Report (VSDrops) Download
βœ… monotouch (MacCatalyst): All 24 tests passed. Html Report (VSDrops) Download
βœ… monotouch (macOS): All 24 tests passed. [attempt 4] Html Report (VSDrops) Download
βœ… monotouch (tvOS): All 21 tests passed. Html Report (VSDrops) Download
βœ… msbuild: All 2 tests passed. Html Report (VSDrops) Download
βœ… sharpie: All 1 tests passed. Html Report (VSDrops) Download
βœ… windows: All 3 tests passed. Html Report (VSDrops) Download
βœ… xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
βœ… xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

βœ… Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
βœ… Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

βœ… Linux build succeeded

Pipeline on Agent
Hash: 39bfb36dd9c115b3f2e2c34a279352f084bb8e03 [PR build]

@rolfbjarne
rolfbjarne merged commit ed2342f into main Jun 22, 2026
56 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/fix-template-loc-config branch June 22, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chinese and Polish translations for templates haven't been updated in a long time

4 participants